Stale watermark after partition revoked fix#36
Merged
HubertTatar merged 3 commits intoadform:masterfrom Aug 3, 2023
Merged
Conversation
added 2 commits
July 31, 2023 16:30
…nvokes empty default implementation from io.micrometer.core.instrument.Meter.
HubertTatar
approved these changes
Aug 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We noticed bug where some loaders appeared to have linearly growing watermark.delay.ms. Investigation revealed that after consumer rebalance loaders still emit watermark.delay.ms metric for parition that they not longer consume. This PR adds logic to remove watermark gauge from metric registry after partion revoked event.
I belive .close() call on removed gauges was meant to remove metric, but this function only invokes empty default implementation form https://github.com/micrometer-metrics/micrometer/blob/1.10.x/micrometer-core/src/main/java/io/micrometer/core/instrument/Meter.java#L483. This method is not overriden in Gauge.