Skip to content

Conversation

@lukas-reineke
Copy link
Contributor

I only check in circle, instead of using that build for npm, because I
like that we have the final bundle in git too.

Unit Test Coverage / Review Requirements

  • Are the changes in this PR covered by unit tests?
    • no
  • Does this PR create or modify code without tests? If so, please explain.
    • tools

How to Test

circle

Changelog

  • adds circle build test

I only check in circle, instead of using that build for npm, because I
like that we have the final bundle in git too.
@rmcauley
Copy link
Contributor

🐴

@rmcauley rmcauley merged commit 3630f0e into adgorithmics-inc:master Dec 17, 2019
@lukas-reineke lukas-reineke deleted the T-335-build-the-sdk-in-circle-to-prevent-prs-that-have-not-matching-code-=>-build branch December 17, 2019 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants