Skip to content

Update to latest Cinna API, add string[] types to fields #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lukas-reineke merged 1 commit into from
Dec 17, 2019
Merged

Update to latest Cinna API, add string[] types to fields #55

lukas-reineke merged 1 commit into from
Dec 17, 2019

Conversation

@rmcauley
Copy link
Contributor

@rmcauley rmcauley commented Dec 17, 2019

Unit Test Coverage / Review Requirements

  • Are the changes in this PR covered by unit tests?
    • No
  • Does this PR create or modify code without tests? If so, please explain.
    • Type and generated files updates

How to Test

  • Make sure fields arguments can accept string[] types

Changelog

  • [Change] In Typescript, fields arguments can now take string[] as a type.

Notes

None

@lukas-reineke lukas-reineke self-assigned this Dec 17, 2019
@lukas-reineke lukas-reineke merged commit 62ab5c8 into adgorithmics-inc:master Dec 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@lukas-reineke lukas-reineke lukas-reineke approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@lukas-reineke lukas-reineke

Labels

Awaiting :馬: Tests Not Required

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rmcauley @lukas-reineke