Skip to content

Conversation

@dimtrovich
Copy link
Contributor

see #68

@adhocore
Copy link
Owner

adhocore commented Jul 9, 2022

thanks a lot, would you wait a little for me to review it sometimes next week :)

@adhocore
Copy link
Owner

adhocore commented Jul 9, 2022

btw what do you think about this? https://github.com/adhocore/php-cli/pull/new/68-command-group (i had hacked on this before seeing your PR)

image


<?php

$app = new Ahc\Cli\Application('console', '0.0.1');

$app
    ->command('db:create', 'db create', 'dc')->tap()
    ->command('app:init', 'app init', 'ai')->tap()
    ->command('routelist', 'route list', 'rl')->tap()
    ->command('db:seed', 'db seed', 'ds')->tap()
    ->command('routegen', 'route gen', 'rg')->tap()
    ->command('app:env', 'app env', 'ae')->tap()
;

$app->handle($_SERVER['argv'] ?? []);

@dimtrovich
Copy link
Contributor Author

thanks a lot, would you wait a little for me to review it sometimes next week :)

Hi!!! I've been waiting for your response ever since!!! have you forgotten 😒😢

@adhocore
Copy link
Owner

adhocore commented Sep 12, 2022

helo, i was going thru rough times lately.
would you pls try to align the approach and styling similar to https://github.com/adhocore/php-cli/pull/new/68-command-group
(it would be nice to have as little code change as possible)

@adhocore
Copy link
Owner

adhocore commented Oct 1, 2022

hi, could you pls try to apply the feedback, add docs to readme and make the build pass? so i can accept the PR as hacktoberfest-accepted on your behalf.
(or if you lost interest on it then we can close this PR as well)

@dimtrovich
Copy link
Contributor Author

ok, I'll put the comments on all my edits.
for code alignment, it would be interesting if you set up a coding style (with cs-fixer for example)

@adhocore
Copy link
Owner

adhocore commented Oct 2, 2022

i think you misunderstood. i meant this:

would you pls try to align the approach and styling similar to adhocore/php-cli/pull/new/68-command-group
(it would be nice to have as little code change as possible)

@adhocore adhocore mentioned this pull request Oct 8, 2022
@adhocore adhocore closed this in #72 Oct 8, 2022
@adhocore
Copy link
Owner

adhocore commented Oct 8, 2022

helo @dimtrovich , i have fixed it in #72, and released v1.2.0 with credits to you as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants