Skip to content

Minor spelling and label fixes#371

Merged
jlblcc merged 8 commits intoadiwg:developfrom
dvonanderson:fix/276-278-273
Jan 15, 2020
Merged

Minor spelling and label fixes#371
jlblcc merged 8 commits intoadiwg:developfrom
dvonanderson:fix/276-278-273

Conversation

@dvonanderson
Copy link
Copy Markdown
Contributor

Changed "attribute" table name to "attribute name" in "dictionary.show.edit.entity" route

  • app/pods/components/object/md-entity/template.hbs


image

Changed "domain add item" table name to "domain item name" in "dictionary.show.edit.domain" route

  • app/pods/components/object/md-domain/template.hbs


image

Changed "entity keys" table name for foreign keys from "foreign key attribute" to "foreign key" in the

  • app/pods/components/object/md-entity/template.hbs

image

Resolves #276
Resolves #278
Resolves #273

- md-entity template array-table title was changed to foreign key
- fixed integration test to reflect changes

Resolves #278
- new label for entity attribute is "attribute name"
- new label for domain item is "domain item name"
Resolves #276
Resolves #278
Resolves #273

This reverts commit 490b264.
Resolves #276
Resolves #273
Resolves #278
@jlblcc
Copy link
Copy Markdown
Member

jlblcc commented Jan 15, 2020

Looks good. Ready to merge?

@dvonanderson
Copy link
Copy Markdown
Contributor Author

dvonanderson commented Jan 15, 2020 via email

@jlblcc jlblcc merged commit 01e1986 into adiwg:develop Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants