revert #28 and add tests#29
Merged
sjakobs merged 2 commits intoApr 30, 2026
Merged
Conversation
sjakobs
previously approved these changes
Apr 27, 2026
pm-nilesh-chate
force-pushed
the
revert-28-PBX-3382-be-address-empty-device-id-incident
branch
from
909c364 to
e6cf924
Compare
pm-nilesh-chate
changed the title
pm-nilesh-chate
force-pushed
the
revert-28-PBX-3382-be-address-empty-device-id-incident
branch
2 times, most recently
from
2821649 to
36deab2
Compare
…vert to … (adjoeio#28)" This reverts commit 7fec125.
pm-nilesh-chate
force-pushed
the
revert-28-PBX-3382-be-address-empty-device-id-incident
branch
from
36deab2 to
f7501fd
Compare
sjakobs
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #28
Issue: All the SaveItemsWithContext fail!
Reason:
This check is being applied to SaveItemsWithContext where hashkey is not required