Fix(stream): read based on allowed to take jobs#8
Merged
saber-solooki merged 1 commit intomainfrom May 14, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The last problem regarding reading the correct number of tasks based on max_jobs has been mitigated, but there is still a small corner case. Jobs can take time differently. So, imagine a worker is allowed to handle 5 tasks concurrently. 1 of them finished sooner than the others. Now this condition will be passed since job_counter is 4 and max_job is 5. But stream still reads 5 events and as soon as the first job gets started, this condition will be met and the remaining 4 tasks will be ignored.
This PR addressed this issue by always reading the correct number of tasks from the stream