Skip to content

Clarify values of boolean parameters in GET Statements#609

Merged
andyjohnson merged 3 commits intoadlnet:masterfrom
garemoko:issue-356
Mar 2, 2015
Merged

Clarify values of boolean parameters in GET Statements#609
andyjohnson merged 3 commits intoadlnet:masterfrom
garemoko:issue-356

Conversation

@garemoko
Copy link
Copy Markdown
Contributor

@garemoko garemoko commented Feb 4, 2015

Fixes #536

I may have gone off piste with formatting here. Feel free to critique.

@garemoko
Copy link
Copy Markdown
Contributor Author

garemoko commented Feb 4, 2015

And the formatting doesn't work in tables... fixing...

xAPI.md Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, using double quoted strings might lead some people to try putting strings there. Maybe code-formatting instead of quoting? Same below for the other two occurrences.

@andyjohnson
Copy link
Copy Markdown
Contributor

I'd recommend using single quotes for all of the values as they don't actually take on booleans as the code tag may suggest. How do others feel about it?

@garemoko
Copy link
Copy Markdown
Contributor Author

garemoko commented Feb 5, 2015

I quite like the code tags for values. A quick look through the spec suggests that we generally (but not always) use double quotes for values, but since we're using those for properties, that's probably unhelpful. There's actually a lot of properties in single quotes.

@andyjohnson
Copy link
Copy Markdown
Contributor

+1, once I sat down and looked at the styles more carefully I realize a sweep is needed - this PR does what it should!

@ljwolford
Copy link
Copy Markdown
Contributor

+1

andyjohnson added a commit that referenced this pull request Mar 2, 2015
Clarify values of boolean parameters in GET Statements
@andyjohnson andyjohnson merged commit 8211fea into adlnet:master Mar 2, 2015
@garemoko garemoko deleted the issue-356 branch March 2, 2015 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make explicit what value(s) a "Boolean" query string parameter takes

4 participants