Clarify values of boolean parameters in GET Statements#609
Clarify values of boolean parameters in GET Statements#609andyjohnson merged 3 commits intoadlnet:masterfrom
Conversation
|
And the formatting doesn't work in tables... fixing... |
xAPI.md
Outdated
There was a problem hiding this comment.
Hmm, using double quoted strings might lead some people to try putting strings there. Maybe code-formatting instead of quoting? Same below for the other two occurrences.
|
I'd recommend using single quotes for all of the values as they don't actually take on booleans as the code tag may suggest. How do others feel about it? |
|
I quite like the code tags for values. A quick look through the spec suggests that we generally (but not always) use double quotes for values, but since we're using those for properties, that's probably unhelpful. There's actually a lot of properties in single quotes. |
|
+1, once I sat down and looked at the styles more carefully I realize a sweep is needed - this PR does what it should! |
|
+1 |
Clarify values of boolean parameters in GET Statements
Fixes #536
I may have gone off piste with formatting here. Feel free to critique.