Skip to content

two definitions of profile#969

Closed
garemoko wants to merge 1 commit intoadlnet:1.0.3from
garemoko:issue-967
Closed

two definitions of profile#969
garemoko wants to merge 1 commit intoadlnet:1.0.3from
garemoko:issue-967

Conversation

@garemoko
Copy link
Copy Markdown
Contributor

@garemoko garemoko commented Aug 8, 2016

Fixes #967

Will probably conflict #961 and should be merged after.

@andyjohnson
Copy link
Copy Markdown
Contributor

+1

@bscSCORM
Copy link
Copy Markdown
Contributor

This is an improvement, and therefore 👍 to merging it, however I don't think it's the complete / best resolution of #967. Note that pretty much everywhere we use meaning 1 of profile, we are using it together with API, eg: "Activity Profile API"

So I have 2 suggestions related to this

  1. Instead of having parts 1) and 2) for the definition of "profile", define "profile" and "Profile API" as distinct terms.

  2. the word "API" in this context is confusing, since xAPI itself is an API and it's not really another API we're defining. We should probably rather be talking about, for example, the "Activity profile resource".

@garemoko
Copy link
Copy Markdown
Contributor Author

See discussion back at the issue too. Seems this PR needs a lot more work. I might re-do it once #961 merges, but lets leave this open for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants