You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is an improvement, and therefore 👍 to merging it, however I don't think it's the complete / best resolution of #967. Note that pretty much everywhere we use meaning 1 of profile, we are using it together with API, eg: "Activity Profile API"
So I have 2 suggestions related to this
Instead of having parts 1) and 2) for the definition of "profile", define "profile" and "Profile API" as distinct terms.
the word "API" in this context is confusing, since xAPI itself is an API and it's not really another API we're defining. We should probably rather be talking about, for example, the "Activity profile resource".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #967
Will probably conflict #961 and should be merged after.