Skip to content

Prefer "Total Learning Architecture"#992

Merged
andyjohnson merged 2 commits intoadlnet:1.0.3from
oconnetf:patch-5
Sep 7, 2016
Merged

Prefer "Total Learning Architecture"#992
andyjohnson merged 2 commits intoadlnet:1.0.3from
oconnetf:patch-5

Conversation

@oconnetf
Copy link
Copy Markdown
Contributor

Fixes #988.

@andyjohnson
Copy link
Copy Markdown
Contributor

Yep, thanks for this change. +1.

@garemoko
Copy link
Copy Markdown
Contributor

Why the change in line length?

@oconnetf
Copy link
Copy Markdown
Contributor Author

Honestly, this came from our internal doc practice from GitHub. I think I did it reflexively more than consciously.

When editing docs, if each sentence is a full line, it's much easier to see changes within a given sentence.

I'm happy to unwind to something more closely resembling original line lengths.

@garemoko
Copy link
Copy Markdown
Contributor

garemoko commented Sep 1, 2016

The spec has some specific-ish line lengths which are basically about the width of a normal sized window when viewing the markdown. In fact @andyjohnson recently went through and adjusted a large number of lines to make the lengths the same.

I can definitely see the logic in your approach but 'that's not the way we do things round here' and consistency is more important.

Accord with current practices.
@oconnetf
Copy link
Copy Markdown
Contributor Author

oconnetf commented Sep 1, 2016

Point taken. Edit made. Change committed.

@garemoko
Copy link
Copy Markdown
Contributor

garemoko commented Sep 1, 2016

+1

@andyjohnson
Copy link
Copy Markdown
Contributor

+1 and merging. Thanks for the catch in the line breaks.

@andyjohnson andyjohnson merged commit 1caf3a8 into adlnet:1.0.3 Sep 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants