Skip to content

Comments

[pull] master from junegunn:master#175

Merged
pull[bot] merged 1 commit intoadmariner:masterfrom
junegunn:master
Mar 24, 2025
Merged

[pull] master from junegunn:master#175
pull[bot] merged 1 commit intoadmariner:masterfrom
junegunn:master

Conversation

@pull
Copy link

@pull pull bot commented Mar 24, 2025

See Commits and Changes for more details.


Created by pull[bot] (v2.0.0-alpha.1)

Can you help keep this open source service alive? 💖 Please sponsor : )

Summary by Sourcery

Fixes a bug where the cursor was placed incorrectly when the input window was not nil. The cursor position is now capped to the width of the input window.

Bug Fixes:

  • Fixes a bug where the cursor was placed incorrectly when the input window was not nil.
  • Caps the cursor position to the width of the input window.

  e.g.
    fzf --preview 'cat {}' --prompt "$(seq 100 | xargs)"
    fzf --preview 'cat {}' --prompt "$(seq 100 | xargs)" --input-border
@pull pull bot added the ⤵️ pull label Mar 24, 2025
@pull pull bot merged commit 2007450 into admariner:master Mar 24, 2025
@sourcery-ai
Copy link

sourcery-ai bot commented Mar 24, 2025

Reviewer's Guide by Sourcery

This pull request modifies the cursor placement logic to prevent it from going out of bounds and adds a pre-task function to the printHighlighted method.

Sequence diagram for printHighlighted with preTask

sequenceDiagram
  participant Terminal
  participant tui
  Terminal->>Terminal: withWindow(inputWindow, func())
  activate Terminal
  Terminal->>Terminal: promptLine()
  Terminal->>Terminal: preTask(markerClass)
  Terminal->>tui: printHighlighted(Result, ColPrompt, ColPrompt, false, false, line, line, true, preTask, nil)
  deactivate Terminal
Loading

Sequence diagram for placeCursor

sequenceDiagram
  participant Terminal
  participant inputWindow
  Terminal->>Terminal: inputless
  alt inputless == false
    Terminal->>Terminal: inputWindow != nil
    alt inputWindow != nil
      Terminal->>inputWindow: Height()
      Terminal->>inputWindow: Width()
      Terminal->>inputWindow: Move(y, x)
    else inputWindow == nil
      Terminal->>Terminal: move(t.promptLine(), x, false)
    end
  end
Loading

File-Level Changes

Change Details Files
Modified the cursor placement logic to ensure it stays within the bounds of the input window or the main window.
  • Added a check to ensure the cursor's x-coordinate does not exceed the width of the input window.
  • Added a check to ensure the cursor's x-coordinate does not exceed the width of the main window.
  • Introduced a variable x to hold the column position of the cursor.
src/terminal.go
Added a pre-task function to the printHighlighted method.
  • Added a preTask function that returns 1.
  • Passed the preTask function to the printHighlighted method.
src/terminal.go

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant