[pull] master from junegunn:master#175
Merged
pull[bot] merged 1 commit intoadmariner:masterfrom Mar 24, 2025
Merged
Conversation
e.g.
fzf --preview 'cat {}' --prompt "$(seq 100 | xargs)"
fzf --preview 'cat {}' --prompt "$(seq 100 | xargs)" --input-border
Reviewer's Guide by SourceryThis pull request modifies the cursor placement logic to prevent it from going out of bounds and adds a pre-task function to the printHighlighted method. Sequence diagram for printHighlighted with preTasksequenceDiagram
participant Terminal
participant tui
Terminal->>Terminal: withWindow(inputWindow, func())
activate Terminal
Terminal->>Terminal: promptLine()
Terminal->>Terminal: preTask(markerClass)
Terminal->>tui: printHighlighted(Result, ColPrompt, ColPrompt, false, false, line, line, true, preTask, nil)
deactivate Terminal
Sequence diagram for placeCursorsequenceDiagram
participant Terminal
participant inputWindow
Terminal->>Terminal: inputless
alt inputless == false
Terminal->>Terminal: inputWindow != nil
alt inputWindow != nil
Terminal->>inputWindow: Height()
Terminal->>inputWindow: Width()
Terminal->>inputWindow: Move(y, x)
else inputWindow == nil
Terminal->>Terminal: move(t.promptLine(), x, false)
end
end
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )
Summary by Sourcery
Fixes a bug where the cursor was placed incorrectly when the input window was not nil. The cursor position is now capped to the width of the input window.
Bug Fixes: