Skip to content

Comments

[pull] master from junegunn:master#177

Merged
pull[bot] merged 1 commit intoadmariner:masterfrom
junegunn:master
Mar 25, 2025
Merged

[pull] master from junegunn:master#177
pull[bot] merged 1 commit intoadmariner:masterfrom
junegunn:master

Conversation

@pull
Copy link

@pull pull bot commented Mar 25, 2025

See Commits and Changes for more details.


Created by pull[bot] (v2.0.0-alpha.1)

Can you help keep this open source service alive? 💖 Please sponsor : )

Summary by Sourcery

Fix input handling in the terminal by removing the inputless condition and add a test for the no-input query feature.

Bug Fixes:

  • Fix input handling in the terminal by removing unnecessary inputless condition.

Tests:

  • Add a test case for the no-input query feature to ensure correct behavior when toggling input.

* The initial query given by --query should be respected
* The current query should still be respected after `hide-input`
  (or `toggle-input)

Fix #4327
@pull pull bot added the ⤵️ pull label Mar 25, 2025
@pull pull bot merged commit f43e82f into admariner:master Mar 25, 2025
@sourcery-ai
Copy link

sourcery-ai bot commented Mar 25, 2025

Reviewer's Guide by Sourcery

The pull request introduces a new test case for the --no-input option in the test suite and simplifies the input handling logic in the terminal source code.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Added a new test case for the --no-input option in the test suite.
  • Introduced a new test method test_no_input_query.
  • The test simulates a sequence of 1000 numbers and uses the --no-input and --query options.
  • The test checks for the presence of the query result and toggles input with a space key.
test/test_core.rb
Simplified the input handling logic in the terminal source code.
  • Removed the conditional check for t.inputless when assigning src.
  • Directly assigned t.input to src without checking t.inputless.
src/terminal.go

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant