[pull] master from junegunn:master#178
Merged
pull[bot] merged 1 commit intoadmariner:masterfrom Mar 26, 2025
Merged
Conversation
fzf would restore the original query in input-less mode after executing a chain of actions. This commit changes the behavior so that the restoration happens after each action to allow something like 'show-input+change-query(...)+hide-input'. Fix #4326
Reviewer's Guide by SourceryThis pull request enhances the behavior of fzf when the input section is hidden (--no-input) by preserving and restoring the query, allowing users to change the query even when the input is not visible. It also includes a new test case to ensure the correctness of this functionality. Sequence diagram for handling actions with hidden inputsequenceDiagram
participant Terminal
participant Action
Terminal->>Terminal: Loop()
Terminal->>Terminal: doAction(action)
activate Terminal
Terminal->>Terminal: currentInput := t.input
Terminal->>Action: Execute action
activate Action
Action-->>Terminal: Action completed
deactivate Action
alt t.inputless
Terminal->>Terminal: t.input = currentInput
Terminal->>Terminal: t.cx = len(t.input)
end
deactivate Terminal
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )
Summary by Sourcery
Tests: