Skip to content

Comments

[pull] master from junegunn:master#178

Merged
pull[bot] merged 1 commit intoadmariner:masterfrom
junegunn:master
Mar 26, 2025
Merged

[pull] master from junegunn:master#178
pull[bot] merged 1 commit intoadmariner:masterfrom
junegunn:master

Conversation

@pull
Copy link

@pull pull bot commented Mar 26, 2025

See Commits and Changes for more details.


Created by pull[bot] (v2.0.0-alpha.1)

Can you help keep this open source service alive? 💖 Please sponsor : )

Summary by Sourcery

Tests:

  • Adds a test case to verify the ability to change the query when the input is hidden.

fzf would restore the original query in input-less mode after executing
a chain of actions.

This commit changes the behavior so that the restoration
happens after each action to allow something like
'show-input+change-query(...)+hide-input'.

Fix #4326
@pull pull bot added the ⤵️ pull label Mar 26, 2025
@pull pull bot merged commit 4a0ab6c into admariner:master Mar 26, 2025
@sourcery-ai
Copy link

sourcery-ai bot commented Mar 26, 2025

Reviewer's Guide by Sourcery

This pull request enhances the behavior of fzf when the input section is hidden (--no-input) by preserving and restoring the query, allowing users to change the query even when the input is not visible. It also includes a new test case to ensure the correctness of this functionality.

Sequence diagram for handling actions with hidden input

sequenceDiagram
  participant Terminal
  participant Action

  Terminal->>Terminal: Loop()
  Terminal->>Terminal: doAction(action)
  activate Terminal
  Terminal->>Terminal: currentInput := t.input
  Terminal->>Action: Execute action
  activate Action
  Action-->>Terminal: Action completed
  deactivate Action
  alt t.inputless
    Terminal->>Terminal: t.input = currentInput
    Terminal->>Terminal: t.cx = len(t.input)
  end
  deactivate Terminal
Loading

File-Level Changes

Change Details Files
Preserves and restores the query when the input section is hidden (--no-input) to allow changing the query even when the input is hidden.
  • Saves the current input before each action.
  • Restores the input after each action if the input is hidden.
  • Discards query changes if inputless.
src/terminal.go
Added a test case to verify query changes when input is hidden.
  • Verifies that the query can be changed and restored when the input is hidden using show-input, change-query, and hide-input actions.
  • Verifies that the query can be changed when the input is hidden using change-query and select actions.
test/test_core.rb

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant