Skip to content

Comments

[pull] master from junegunn:master#180

Merged
pull[bot] merged 4 commits intoadmariner:masterfrom
junegunn:master
Mar 28, 2025
Merged

[pull] master from junegunn:master#180
pull[bot] merged 4 commits intoadmariner:masterfrom
junegunn:master

Conversation

@pull
Copy link

@pull pull bot commented Mar 28, 2025

See Commits and Changes for more details.


Created by pull[bot] (v2.0.0-alpha.1)

Can you help keep this open source service alive? 💖 Please sponsor : )

Summary by Sourcery

Add new dynamic configuration actions for ghost text and pointer in fzf

New Features:

  • Added ability to dynamically change ghost text using change-ghost and transform-ghost actions
  • Added ability to dynamically change pointer sign using change-pointer and transform-pointer actions

Enhancements:

  • Updated action type constants to support new ghost and pointer configuration actions
  • Updated documentation and man pages to include new actions
  • Added test cases for new dynamic configuration features

junegunn and others added 4 commits March 28, 2025 21:28
Bumps [github.com/charlievieth/fastwalk](https://github.com/charlievieth/fastwalk) from 1.0.9 to 1.0.10.
- [Release notes](https://github.com/charlievieth/fastwalk/releases)
- [Commits](charlievieth/fastwalk@v1.0.9...v1.0.10)

---
updated-dependencies:
- dependency-name: github.com/charlievieth/fastwalk
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@pull pull bot added the ⤵️ pull label Mar 28, 2025
@pull pull bot merged commit ba6d1b8 into admariner:master Mar 28, 2025
@sourcery-ai
Copy link

sourcery-ai bot commented Mar 28, 2025

Reviewer's Guide by Sourcery

This pull request introduces the ability to dynamically change the ghost text and pointer sign, fixes an issue where the header window was not being resized when the header content changed, and updates go modules.

Sequence diagram for changing the header

sequenceDiagram
    participant Terminal
    Terminal->Terminal: changeHeader(header)
    alt headerWindow != nil
        Terminal->Terminal: req(reqFullRedraw)
    else
        Terminal->Terminal: req(reqHeader, reqList, reqPrompt, reqInfo)
    end
Loading

Sequence diagram for changing ghost text

sequenceDiagram
    participant Terminal
    Terminal->Terminal: Handle actChangeGhost or actTransformGhost
    Terminal->Terminal: t.ghost = ghost
    alt len(t.input) == 0
        Terminal->Terminal: req(reqPrompt)
    end
Loading

Sequence diagram for changing pointer

sequenceDiagram
    participant Terminal
    Terminal->Terminal: Handle actChangePointer or actTransformPointer
    Terminal->Terminal: t.pointer = pointer
    Terminal->Terminal: t.pointerLen = length
    Terminal->Terminal: t.pointerEmpty = strings.Repeat(" ", t.pointerLen)
    Terminal->Terminal: req(reqList)
Loading

File-Level Changes

Change Details Files
Introduces new actions to dynamically change the ghost text and pointer sign.
  • Added actChangeGhost and actTransformGhost action types.
  • Added actChangePointer and actTransformPointer action types.
  • Implemented the corresponding logic in the Loop function to handle these actions, allowing users to dynamically update the ghost text and pointer.
  • Updated the executeRegexp to include the new actions.
  • Updated the man page to reflect the new actions.
  • Updated the changelog to reflect the new actions.
src/actiontype_string.go
src/terminal.go
test/test_core.rb
src/options.go
man/man1/fzf.1
CHANGELOG.md
Fixes an issue where the header window was not being resized when the header content changed.
  • Added a check to see if the header window is nil before redrawing the header.
  • If the header window is not nil, a full redraw is requested.
src/terminal.go
Updates go modules.
  • Updated github.com/charlievieth/fastwalk from v1.0.9 to v1.0.10
  • Updated github.com/junegunn/go-shellwords v0.0.0-20250127100254-2aa3b3277741
go.mod
go.sum

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant