This repository was archived by the owner on Feb 15, 2024. It is now read-only.
Feature/example validation#40
Merged
FrankSchnicke merged 16 commits intomainfrom Oct 22, 2021
Merged
Conversation
Feature/example validation
Signed-off-by: Frank Schnicke <frank.schnicke@iese.fraunhofer.de>
Feature/example validation
…on for EmbeddedDataSpecifications
mjacoby
reviewed
Oct 22, 2021
| .preferredName(new LangString(DIGITAL_FILE, "EN")) | ||
| .shortName(new LangString(DIGITAL_FILE, "EN")) | ||
| .shortName(new LangString(DIGITALE_DATEI, "DE")).unit("ExampleString").sourceOfDefinition("ExampleString") | ||
| .dataType(DataTypeIEC61360.STRING).definition(new LangString(DIGITAL_FILE_DEFINITION, "EN")) |
Contributor
There was a problem hiding this comment.
Language tag was changed from DE to EN but content of string DIGITAL_FILE_DEFINITION is still in German. Either change language tag back to EN or change content of string to English.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All tests of the validation pass, also all shapes are corrected. Looks like the Validator does what it should.