BatteryPass Aspect Models of joint Catena-X/IDTA expert modelling group - Version for Review

[BirgitBoss]

This is the branch for incorporating the findings of the review.The original branch for the review can be see here: #33

[BirgitBoss]

If you have any findings you want to submit via PR please provide them to the branch https://github.com/admin-shell-io/smt-semantic-models/tree/smt-xg/BatteryPass_Working

[tobzahn]

General questions:

• where are the formats and units specified? E.g. there are some temperatures - where is it specified what unit (Celcius, Fahrenheit) is to be used? Or for date attributes, what data format (e.g. YYYY-MM-DD or YYYY-DD-MM) to be used?
• Is it correct that dynamic data (to be updated while the battery is in operation) is only to be found in batterypass.product_condition? Therefore, all other data models are to be filled out by the manufacturer and remain unchanged (static)?
• Will there be a textual document (e.g. a Catena-X Standard) that explains how to use the data model, how to make it available to customers and how the exchange is supposed to work?

[BirgitBoss]

reopened because this PR was mentioned to be the one to add changes in the call for review in Catena-X.

[BirgitBoss]

General questions:

* where are the formats and units specified? E.g. there are some temperatures - where is it specified what unit (Celcius, Fahrenheit) is to be used? Or for date attributes, what data format (e.g. YYYY-MM-DD or YYYY-DD-MM) to be used?

In Aspect Models unit handling see https://eclipse-esmf.github.io/samm-specification/snapshot/units.html and https://eclipse-esmf.github.io/samm-specification/snapshot/appendix/unitcatalog.html
As .ttl. file the units can be found here

If units are missing then a corresponding issue shall be raised. If it is missing in referenced reused model the issue shall be raised in the corresponding github of the reused model.

* Is it correct that dynamic data (to be updated while the battery is in operation) is only to be found in batterypass.product_condition? Therefore, all other data models are to be filled out by the manufacturer and remain unchanged (static)?

yes, this is the intention. If you find any dynamic data in other models this should be considered a bug

* Will there be a textual document (e.g. a Catena-X Standard) that explains how to use the data model, how to make it available to customers and how the exchange is supposed to work?

sure,

• there is a Submodel Template Specificaitions (SMT) document for every single Aspect Model (also part of the review)
• there is overview document of all SMT for Battery Pass (also part of the review)
• there will be an update of existing Catena-X standards and KITs how to use it

[manourym]

Additional comment addressed here: eclipse-tractusx/sldt-semantic-models#876 (comment)

I got feedback that some values are still missing regarding the pcf ammendment to te battery regulation (here) that need to be tested already with the suppliers. Therefore, this model shall be created. I will put the feedback also in the batterypass review. Here the feedback:

Attribute	Description	Refrence to Annex of Regulation Draft
Specific content and the carbon footprint of metals and metal salts	The specific content and the carbon footprint of metals and metal salts that are targeted by the default battery cell recycling process, 6, at least regarding steel, aluminium, copper, cobalt, nickel, manganese, lithium, graphite, silicon, titanium, vanadium, silver, gold, platinum group metals and phosphorous. If such metals and metal salts contain recycled content, the carbon footprint of EV_Mat and Erecycled_Mat as defined in section 2.6 shall be provided.	2.3.1. Mandatory company-specific processes
Product quality parameters	Product quality parameters affecting product carbon footprint, such as purity or specific capacity	2.3.1. Mandatory company-specific processes
Technological Representativeness – TeR	The degree to which the data reflects the actual technology(ies) used. A value between 1 and 5.	2.3.6. Data quality ratings
Geographical Representativeness – GeR	Geographical representativeness. The degree to which the data reflects the actual geographic location of the manufacturing process. A value between 1 and 5.	2.3.6. Data quality ratings
Time-related Representativeness – TiR	The degree to which the reference period is for the data set is close to the issue date.  A value between 1 and 5.	2.3.6. Data quality ratings
Data Quality Rating - DQR	Data Quality Rating (DQR) calculated based on the DQR criteria TeR, TiR and GeR.	2.3.6. Data quality ratings

[sebastiankb]

General comments:

• all models from IDTA have already its own semantic IDs; the aspect models overrides those semantic IDs with own IDs and move the origin semantic IDs to the supplementical semantic IDs; this was not agreed; design decssion says clear that existing semanic IDs should be used
• idShorts of the elements always start with lowercase letters, however, the orign IDTA submodels usually starts with capital letters.

[sebastiankb]

see #10 (comment)

[sebastiankb]

this causes wrong semantic IDs

[BirgitBoss]

There is no roundtrip, you are right but the semanticIds are added via see-attribute

[sebastiankb]

this is should be the semantic ID of the uriOfTheProduct

[BirgitBoss]

IRDI Are not supported as value for see-attribute in SAMM, therefore urn:irdi: added as prefix. The IRDI itself should be correct, no?

[sebastiankb]

if they not show-up in the AAS version, then this is ok

[tobzahn]

Please also see my comments at PR #34