-
Notifications
You must be signed in to change notification settings - Fork 1
Incorporate Findings from Review #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
BirgitBoss
wants to merge
99
commits into
smt-xg/BatteryPass_Working
Choose a base branch
from
BiBo/incorporateFindings_#1
base: smt-xg/BatteryPass_Working
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Incorporate Findings from Review #34
BirgitBoss
wants to merge
99
commits into
smt-xg/BatteryPass_Working
from
BiBo/incorporateFindings_#1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove wrong preferred name fix language for preferred name
- fix language issues - formatting
- adding example value for Logo - formatting
add exampleValue for company logo
tobzahn
reviewed
Sep 5, 2025
io.admin-shell.idta.batterypass.carbon_footprint/1.0.0/gen/CarbonFootprintBattery.json
Outdated
Show resolved
Hide resolved
io.admin-shell.idta.batterypass.technical_data/1.0.0/gen/TechnicalDataBattery.json
Outdated
Show resolved
Hide resolved
io.admin-shell.idta.carbon_footprint.pact/1.0.0/gen/CarbonFootprintPact.json
Show resolved
Hide resolved
io.admin-shell.idta.carbon_footprint.pact/1.0.0/gen/CarbonFootprintPact.json
Show resolved
Hide resolved
io.admin-shell.idta.carbon_footprint.pact/1.0.0/gen/CarbonFootprintPact.json
Show resolved
Hide resolved
minor fixes
Incorporate Findings and complete existing SMT models - 2nd
…ome incorrect license information
update license information - no CC BY-NC 4.0 any longer
…in that it is requested but no deviation any longer
incorporate findings #4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Findings via PR #10
Major Bugs:
Minor Bugs:
Major changes:
<urn:samm:io.BatteryPass.Performance:1.2.1#>instead of bp:<urn:samm:io.BatteryPass.Performance:1.2.0#><urn:samm:io.catenax.pcf:8.0.0#>instead of cx:<urn:samm:io.catenax.pcf:7.0.0#>Improvements:
Please be aware: some of the generated files also changed because of changes in reused Aspect Models from BatteryPass Consortium or Tractus-X/Catena-X, e.g.
DONE:
-- batterypass/BatteryPassDataModel#23: remove editorial special char from descriptions
-- batterypass/BatteryPassDataModel#25: Circularity.ValidEmailAddress wrong regex
-- batterypass/BatteryPassDataModel#27: GeneralProductInformation:1.2.0 exampleValue for addressCountry is wrong
OPEN:
-- batterypass/BatteryPassDataModel#32: NumberOfFullCycles and others should be xsd:positiveInteger
-- batterypass/BatteryPassDataModel#31 ratedEnergy/CertifiedUsableBatteryEnergy: data type & no negative values #31
-- batterypass/BatteryPassDataModel#21 add descriptions to properties
-- batterypass/BatteryPassDataModel#20 optional properties? Add cardinality to Performance, MaeterialComposition and Circularity properties
-- batterypass/BatteryPassDataModel#19 Add example values to Performance, MaeterialComposition and Circularity properties
-- batterypass/BatteryPassDataModel#36 correct typo from
:kilogramperkilowatthourto:KilogramPerKilowattHourOpen issues for generated files (not relevant any longer since .aas files not included, they are manually edited):