editorial changes and adding information

README.md

@@ -33,8 +33,32 @@ Known Issues wehen generating an aasx from aspect model:
 - SubmodelElement File is realized as SMC with two properties
 - no template qualifiers with type "Cardinality" or any other qualifiers are generated
 - the idShort of the Element within a SML has the idShort of the list, not of the element
+- no mapping to SubmodelElement "File", instead mapping to SMC with two properties "resourceValue" and "contentType"
 
 
 # Open Questions
 
-* PowerCapabilityFade was removed from Technical Data? If belonged to Capacity before
+* PowerCapabilityFade was removed from Technical Data? It belonged to Capacity before
+
+
+# Deviations from manually edited aasx of WG
+
+* ProductCondition
+  * batteryStatus missing
+  * "lastUpdate" property for the properties that change over time
+* Nameplate 3.0 should be used, not 2.0
+	* Nameplate: it is AddressInformation and not ContactInformation
+	* Nameplate: logoCompany is missing
+	* Naemplate/Markings: explosionSafeties not  contained in V3.0 any longer
+	* Nameplate/ContactInformation: is a dropin and contains much more properties
+
+* TODOs for BatteryPass reused
+
+    * remainingEnergy: property name should be remainingEnergyValue and not remainingEnergyvalue
+	* why is evolutionOfSelfDischarge a SMC with just one Property evolutionOfSelfDischargeEntityValue?
+	* names of lists like "internalResistanceIncrease" or remainingPowerCapability
+    * no "lastUpdate" for batteryStatus
+    * no "lastUpdate" for energyThroughput
+	* no "lastUpdate" for roundTripEfficencyFade
+	* no "lastUpdate" for roundTripEfficiencyat50PerCentCycleLife 
+	* naming roundTripEfficiencyat50PerCentCycleLife should be roundTripEfficiencyAt50PercentCycleLife

io.admin-shell.idta.batterypass.carbon_footprint/README.md

@@ -11,7 +11,7 @@ The battery passport consists of the following 7 parts:
 *	Digital Battery Passport - Part 3: Product Carbon Footprint  (IDTA-02035-3)
 *	Digital Battery Passport - Part 4: Technical Data (IDTA-02035-4) 
 *	Digital Battery Passport - Part 5: Product Condition  (IDTA-02035-5)
-*	Digital Battery Passport - Part 6: Material Compostion  (IDTA-02035-6)
+*	Digital Battery Passport - Part 6: Material Composition  (IDTA-02035-6)
 *	Digital Battery Passport - Part 7: Circularity  (IDTA-02035-7)
 
 

io.admin-shell.idta.batterypass.circularity/README.md

@@ -14,7 +14,7 @@ The battery passport consists of the following 7 parts:
 *	Digital Battery Passport - Part 3: Product Carbon Footprint  (IDTA-02035-3)
 *	Digital Battery Passport - Part 4: Technical Data (IDTA-02035-4) 
 *	Digital Battery Passport - Part 5: Product Condition  (IDTA-02035-5)
-*	Digital Battery Passport - Part 6: Material Compostion  (IDTA-02035-6)
+*	Digital Battery Passport - Part 6: Material Composition  (IDTA-02035-6)
 *	Digital Battery Passport - Part 7: Circularity  (IDTA-02035-7)
 
 Source GitHub IDTA: https://github.com/admin-shell-io/submodel-templates 

io.admin-shell.idta.batterypass.digital_nameplate/1.0.0/Nameplate.ttl

@@ -29,21 +29,21 @@
    [ samm:property nameplate:uriOfTheProduct; samm:payloadName "URIOfTheProduct" ] 
    [ samm:property nameplate:manufacturerName; samm:payloadName "ManufacturerName" ] 
    [ samm:property nameplate:manufacturerProductDesignation; samm:payloadName "ManufacturerProductDesignation" ] 
+   [ samm:property nameplate:addressInformation; samm:optional true; samm:payloadName "AddressInformation" ] 
+   [ samm:property nameplate:manufacturerProductRoot; samm:optional true; samm:payloadName "ManufacturerProductRoot" ]
    [ samm:property nameplate:manufacturerProductFamily; samm:optional true; samm:payloadName "ManufacturerProductFamily" ] 
    [ samm:property nameplate:manufacturerProductType; samm:optional true; samm:payloadName "ManufacturerProductType" ] 
    [ samm:property nameplate:orderCodeOfManufacturer; samm:payloadName "OrderCodeOfManufacturer" ] 
    [ samm:property nameplate:productArticleNumberOfManufacturer; samm:optional true; samm:payloadName "ProductArticleNumberOfManufacturer" ] 
-   [ samm:property nameplate:addressInformation; samm:optional true; samm:payloadName "AddressInformation" ] 
    [ samm:property nameplate:serialNumber; samm:payloadName "SerialNumber" ] 
    [ samm:property nameplate:yearOfConstruction; samm:payloadName "YearOfConstruction" ] 
    [ samm:property nameplate:dateOfManufacture; samm:optional true; samm:payloadName "DateOfManufacture" ] 
-   [ samm:property nameplate:logoCompany; samm:optional true; samm:payloadName "LogoCompany" ] 
    [ samm:property nameplate:hardwareVersion; samm:optional true; samm:payloadName "HardwareVersion" ] 
    [ samm:property nameplate:firmwareVersion; samm:optional true; samm:payloadName "FirmwareVersion" ] 
    [ samm:property nameplate:softwareVersion; samm:optional true; samm:payloadName "SoftwareVersion" ] 
-   [ samm:property nameplate:manufacturerProductRoot; samm:optional true; samm:payloadName "ManufacturerProductRoot" ] 
    [ samm:property nameplate:countryOfOrigin; samm:payloadName "CountryOfOrigin" ] 
-   [ samm:property nameplate:uniqueFacilityIdentifier; samm:payloadName "UniqueFacilityIdentifier" ] 
+   [ samm:property nameplate:uniqueFacilityIdentifier; samm:payloadName "UniqueFacilityIdentifier" ]
+   [ samm:property nameplate:logoCompany; samm:optional true; samm:payloadName "CompanyLogo" ]   
    [ samm:property nameplate:markings; samm:optional true; samm:payloadName "Markings" ] 
    );
    samm:operations ( ) ;

io.admin-shell.idta.batterypass.handover_documentation/README.md

@@ -13,7 +13,7 @@ The battery passport consists of the following 7 parts:
 *	Digital Battery Passport - Part 3: Product Carbon Footprint  (IDTA-02035-3)
 *	Digital Battery Passport - Part 4: Technical Data (IDTA-02035-4) 
 *	Digital Battery Passport - Part 5: Product Condition  (IDTA-02035-5)
-*	Digital Battery Passport - Part 6: Material Compostion  (IDTA-02035-6)
+*	Digital Battery Passport - Part 6: Material Composition  (IDTA-02035-6)
 *	Digital Battery Passport - Part 7: Circularity  (IDTA-02035-7)
 
 # General

io.admin-shell.idta.batterypass.material_composition/README.md

@@ -11,7 +11,7 @@ The battery passport consists of the following 7 parts:
 *	Digital Battery Passport - Part 3: Product Carbon Footprint  (IDTA-02035-3)
 *	Digital Battery Passport - Part 4: Technical Data (IDTA-02035-4) 
 *	Digital Battery Passport - Part 5: Product Condition  (IDTA-02035-5)
-*	Digital Battery Passport - Part 6: Material Compostion  (IDTA-02035-6)
+*	Digital Battery Passport - Part 6: Material Composition  (IDTA-02035-6)
 *	Digital Battery Passport - Part 7: Circularity  (IDTA-02035-7)
 
 This model is using the models of the BatteryPass Consortium: https://github.com/batterypass/BatteryPassDataModel/tree/main/BatteryPass/io.BatteryPass.MaterialComposition

io.admin-shell.idta.batterypass.product_condition/README.md

@@ -11,7 +11,7 @@ The battery passport consists of the following 7 parts:
 *	Digital Battery Passport - Part 3: Product Carbon Footprint  (IDTA-02035-3)
 *	Digital Battery Passport - Part 4: Technical Data (IDTA-02035-4) 
 *	Digital Battery Passport - Part 5: Product Condition  (IDTA-02035-5)
-*	Digital Battery Passport - Part 6: Material Compostion  (IDTA-02035-6)
+*	Digital Battery Passport - Part 6: Material Composition  (IDTA-02035-6)
 *	Digital Battery Passport - Part 7: Circularity  (IDTA-02035-7)
 
 This model is using parts of the models relevant for dynamic data of the BatteryPass Consortium: https://github.com/batterypass/BatteryPassDataModel/tree/main/BatteryPass/io.BatteryPass.Performance

io.admin-shell.idta.carbon_footprint/README.md

@@ -46,9 +46,9 @@ Dependencies:
 - enumerations are not (yet) modelled
 
 # Known Issues generation of aasx from aspect model:
-- payload names are not considered to be used as idShort
+- payload names are not considered when generating idShort
 - SubmodelElement File is realized as SMC with two properties (ExplanatoryStatement and PcfRuleOnlineReference)
-- not template qualifiers generated
+- no template qualifiers generated
 - the idShort of the Element within a SML has the idShort of the list, not of the element
 - SMC ExternalPcfApi not generated with its properties, properties are missing
 - SMC ProductOrSectorSpecificRule not generated with its properties, properties are missing

io.admin-shell.idta.contact_information/1.0.0/ContactInformation_shared.ttl

@@ -25,7 +25,31 @@
 :ContactInformation a samm:Entity ;
    samm:description "Contains information on how to contact the manufacturer or an authorised service provider, e.g. when a maintenance service is required."@en ;
    samm:see <urn:irdi:0173-1%2302-AAQ837%23005> ;
-   samm:properties ( [ samm:property :roleOfContactPerson; samm:optional true; samm:payloadName "RoleOfContactPerson" ] [ samm:property :nationalCode; samm:optional true; samm:payloadName "NationalCode" ] [ samm:property shared:languages; samm:optional true; samm:payloadName "Languages" ] [ samm:property :timeZone; samm:optional true; samm:payloadName "TimeZone" ]  [ samm:property :cityTown; samm:optional true; samm:payloadName "CityTown" ] [ samm:property :company; samm:optional true; samm:payloadName "Company" ]    [ samm:property :department; samm:optional true; samm:payloadName "Department" ] [ samm:property :phone; samm:optional true; samm:payloadName "Phone" ] [ samm:property :fax; samm:optional true; samm:payloadName "Fax" ] [ samm:property :email; samm:optional true; samm:payloadName "Email" ] [ samm:property :iPCommunicationChannels; samm:optional true; samm:payloadName "IPCommunicationChannels" ]  [ samm:property :street; samm:optional true; samm:payloadName "Street" ] [ samm:property :zipCode; samm:optional true; samm:payloadName "ZipCode" ] [ samm:property :poBox; samm:optional true; samm:payloadName "POBox" ] [ samm:property :zipCodeOfPoBox; samm:optional true; samm:payloadName "ZipCodeOfPOBox" ]  [ samm:property :stateCounty; samm:optional true; samm:payloadName "StateCounty" ] [ samm:property :nameOfContact; samm:optional true; samm:payloadName "NameOfContact" ] [ samm:property :firstName; samm:optional true; samm:payloadName "FirstName" ] [ samm:property :middleNames; samm:optional true; samm:payloadName "MiddleNames" ] [ samm:property :title; samm:optional true; samm:payloadName "Title" ] [ samm:property :academicTitle; samm:optional true; samm:payloadName "AcademicTitle" ] [ samm:property :furtherDetailsOfContact; samm:optional true; samm:payloadName "FurtherDetailsOfContact" ] [ samm:property :addressOfAdditionalLink; samm:optional true; samm:payloadName "AddressOfAdditionalLink" ]) .
+   samm:properties ( 
+   [ samm:property :roleOfContactPerson; samm:optional true; samm:payloadName "RoleOfContactPerson" ] 
+   [ samm:property :nationalCode; samm:optional true; samm:payloadName "NationalCode" ] 
+   [ samm:property shared:languages; samm:optional true; samm:payloadName "Languages" ] 
+   [ samm:property :timeZone; samm:optional true; samm:payloadName "TimeZone" ]  
+   [ samm:property :cityTown; samm:optional true; samm:payloadName "CityTown" ] 
+   [ samm:property :company; samm:optional true; samm:payloadName "Company" ]    
+   [ samm:property :department; samm:optional true; samm:payloadName "Department" ] 
+   [ samm:property :phone; samm:optional true; samm:payloadName "Phone" ] 
+   [ samm:property :fax; samm:optional true; samm:payloadName "Fax" ]
+   [ samm:property :email; samm:optional true; samm:payloadName "Email" ]
+   [ samm:property :iPCommunicationChannels; samm:optional true; samm:payloadName "IPCommunicationChannels" ]
+   [ samm:property :street; samm:optional true; samm:payloadName "Street" ]
+   [ samm:property :zipCode; samm:optional true; samm:payloadName "ZipCode" ]
+   [ samm:property :poBox; samm:optional true; samm:payloadName "POBox" ]
+   [ samm:property :zipCodeOfPoBox; samm:optional true; samm:payloadName "ZipCodeOfPOBox" ] 
+   [ samm:property :stateCounty; samm:optional true; samm:payloadName "StateCounty" ] 
+   [ samm:property :nameOfContact; samm:optional true; samm:payloadName "NameOfContact" ]
+   [ samm:property :firstName; samm:optional true; samm:payloadName "FirstName" ]
+   [ samm:property :middleNames; samm:optional true; samm:payloadName "MiddleNames" ]
+   [ samm:property :title; samm:optional true; samm:payloadName "Title" ]
+   [ samm:property :academicTitle; samm:optional true; samm:payloadName "AcademicTitle" ]
+   [ samm:property :furtherDetailsOfContact; samm:optional true; samm:payloadName "FurtherDetailsOfContact" ]
+   [ samm:property :addressOfAdditionalLink; samm:optional true; samm:payloadName "AddressOfAdditionalLink" ]
+   ) .
 
 
 :typeOfCommunication a samm:Property ;

io.admin-shell.idta.digital_nameplate/3.0.0/Nameplate.ttl

@@ -24,25 +24,25 @@
    samm:preferredName "Typenschild"@de ;
    samm:description "Contains the nameplate information attached to the product."@en ;
    samm:description "Enthält die Information zum Typenschild des Produkts."@de ;
-      samm:properties ( 
+   samm:properties ( 
    [ samm:property :uriOfTheProduct; samm:payloadName "URIOfTheProduct" ] 
    [ samm:property :manufacturerName; samm:payloadName "ManufacturerName" ] 
    [ samm:property :manufacturerProductDesignation; samm:payloadName "ManufacturerProductDesignation" ] 
+   [ samm:property :addressInformation; samm:payloadName "AddressInformation" ] 
+   [ samm:property :manufacturerProductRoot; samm:optional true; samm:payloadName "ManufacturerProductRoot" ]
    [ samm:property :manufacturerProductFamily; samm:optional true; samm:payloadName "ManufacturerProductFamily" ] 
    [ samm:property :manufacturerProductType; samm:optional true; samm:payloadName "ManufacturerProductType" ] 
    [ samm:property :orderCodeOfManufacturer; samm:payloadName "OrderCodeOfManufacturer" ] 
    [ samm:property :productArticleNumberOfManufacturer; samm:optional true; samm:payloadName "ProductArticleNumberOfManufacturer" ] 
-   [ samm:property :addressInformation; samm:payloadName "AddressInformation" ] 
    [ samm:property :serialNumber; samm:optional true; samm:payloadName "SerialNumber" ] 
    [ samm:property :yearOfConstruction; samm:optional true; samm:payloadName "YearOfConstruction" ] 
    [ samm:property :dateOfManufacture; samm:optional true; samm:payloadName "DateOfManufacture" ] 
-   [ samm:property :logoCompany; samm:optional true; samm:payloadName "LogoCompany" ] 
    [ samm:property :hardwareVersion; samm:optional true; samm:payloadName "HardwareVersion" ] 
    [ samm:property :firmwareVersion; samm:optional true; samm:payloadName "FirmwareVersion" ] 
    [ samm:property :softwareVersion; samm:optional true; samm:payloadName "SoftwareVersion" ] 
-   [ samm:property :manufacturerProductRoot; samm:optional true; samm:payloadName "ManufacturerProductRoot" ] 
    [ samm:property :countryOfOrigin; samm:optional true; samm:payloadName "CountryOfOrigin" ] 
    [ samm:property :uniqueFacilityIdentifier; samm:optional true; samm:payloadName "UniqueFacilityIdentifier" ] 
+   [ samm:property :logoCompany; samm:optional true; samm:payloadName "CompanyLogo" ]
    [ samm:property :markings; samm:optional true; samm:payloadName "Markings" ] 
    );
    samm:operations ( ) ;

io.admin-shell.idta.shared/README.md

@@ -43,4 +43,4 @@ NONE
 
 In the following only deviations from IDTA-01001-3-1 are documented:
 
-NONE
+- Markings/MarkingAdditionalText has cardinality 0..* but is a Property: for Marking only one Property MarkingAdditionalText is forseen. No cardinality ZeroToMany