AdminFilter: Skip URI scheme during redirect prefix detection. #198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the case where a redirect to, say, /index.xhtml comes out as http:/index.xhtml instead of the correct URI. This usually happens when the application prefix is empty and its path is /, which matches the first slash after the URI scheme. This patch handles that case by skipping over the URI scheme when looking for the start of the prefix in the request URI. If the scheme cannot be detected in the request URI, the behavior is unchanged. Fixes adminfaces#160.
Contributor
Author
|
If you need an example to test it with, it looks like this bug currently affects |
Contributor
|
Nice catch, thank you @benkard! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the case where a redirect to, say, /index.xhtml comes out
as http:/index.xhtml instead of the correct URI. This usually happens
when the application prefix is empty and its path is /, which matches
the first slash after the URI scheme. This patch handles that case by
skipping over the URI scheme when looking for the start of the prefix
in the request URI.
If the scheme cannot be detected in the request URI, the behavior is
unchanged.
Fixes #160.