Console/log error messages should be presented together

[phil-levy]

Currently, the UMAPI error messages are displayed without being near the parameters that are being sent. This makes it really hard to figure out what call the error message corresponds to. The requestID connects them. Can you put the call info with the return info?

2017-02-01 17:14:20 13396 INFO processor - Adding user with user key: rroe@example.com
2017-02-01 17:14:20 13396 INFO dashboard.owning.action - Added action: {"do": [{"createEnterpriseID": {"lastname": "Roe", "country": "US", "email": "rroe@example.com", "firstname": "Richard", "option": "ignoreIfAlreadyExists"}}], "requestID": "action_2", "user": "rroe@example.com"}
2017-02-01 17:14:20 13396 INFO processor - Adding user with user key: jsmith@example.com
2017-02-01 17:14:20 13396 INFO dashboard.owning.action - Added action: {"do": [{"createEnterpriseID": {"lastname": "Smith", "country": "US", "email": "jsmith@example.com", "firstname": "John", "option": "ignoreIfAlreadyExists"}}], "requestID": "action_3", "user": "jsmith@example.com"}
2017-02-01 17:14:20 13396 DEBUG requests.packages.urllib3.connectionpool - https://usermanagement.adobe.io:443 "POST /v2/usermanagement/action/620049C857E4735B7F000101@AdobeOrg?testOnly=true HTTP/1.1" 200 248
2017-02-01 17:14:20 13396 WARNING dashboard.owning.action - Error requestID: action_1 code: "error.user.belongs_to_another_org" message: "Illegal to invite user from another organization's owned auth src"
2017-02-01 17:14:20 13396 WARNING dashboard.owning.action - Error requestID: action_2 code: "error.user.belongs_to_another_org" message: "Illegal to invite user from another organization's owned auth src"
2017-02-01 17:14:20 13396 WARNING dashboard.owning.action - Error requestID: action_3 code: "error.user.belongs_to_another_org" message: "Illegal to invite user from another organization's owned auth src"

[jamesg123]

Hi Phil,

I am not sure if we can improve the logging too much without repeating the input parameters when each error occurs which could potentially make the log file quite large and repetitive.
The errors are written to the log file as they occur so it may be quite a big change to group the messages up.
I am probably missing something (please clarify if I am) but as the requestID is written in the errors does searching/greping the log file not help filter the output to just the bits you are interested in?

Thanks,
Jim

[phil-levy]

After demoing this in front of a bunch of people, at least the following simple things need to be changed: Log message about the call needs to be DEBUG level. I think is probably fine now. Log message about an error return needs to be ERROR level and repeat the call data

[adobeDan]

@jamesg123 Since you are using the umapi_client.UserAction object to create the actions, you can use the existing execution_errors command on that object to get the error together with the specific command data that produced the error.