fix #141 and other issues. #143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
adobeDan
commented
Apr 4, 2017
adobeDan
commented
- cleaned up connector names in logging
- added filename on CSV unrecognized column error
- catch UMAPI connection failures and fail cleanly
* cleaned up connector names in logging * added filename on CSV unrecognized column error * catch UMAPI connection failures and fail cleanly
This was trickier than it appeared! Now that the logging of matched, excluded, and updated users is all at the debug level, we don't need to be so careful about logging them. Basically, we should always log them unless there is not chance they might be affected by their status.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.