Skip to content

Conversation

@phil-levy
Copy link
Contributor

No description provided.

@phil-levy phil-levy requested review from adobeDan and jabogart April 8, 2017 00:22
Copy link
Contributor

@adobeDan adobeDan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think fixes are needed. See the comments.

README.md Outdated
@@ -1,3 +1,16 @@
# Adobe User Sync Tool
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a pretty sacrosanct Github tradition to tile the readme with the project name. Is there really a need to violate that here?

README.md Outdated
@@ -1,3 +1,16 @@
# Adobe User Sync Tool

The Adobe User Sync Tool is a command-line tool that moves user and group information from an organization's enterprise
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Adobe User Sync Tool" violates brand name guidelines and can't be used. You have to say "User Sync Tool from Adobe"

README.md Outdated
- [Step-by-Step Setup](https://adobe-apiplatform.github.io/user-sync.py/success-guide/)
- [Non-Technical Overview](https://spark.adobe.com/page/E3hSsLq3G1iVz/)

# user-sync.py
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This header and the first paragraph now seem redundant. The material in the second paragraph (open source, etc., and the copyright) need to be further up in the file, as in immedately after the first paragraph.

I also think you can remove the Overview section, and go to Requirements right after Quick Links.

Copy link
Contributor

@adobeDan adobeDan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, and nice solomonic solution to the header issue :).

@adobeDan adobeDan merged commit 485de34 into v2 Apr 8, 2017
@adobeDan adobeDan deleted the phil-levy-readme-patch-1 branch April 8, 2017 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants