installable via pip #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
_pri and _sec is awkward. _a and _b is clearer.
(not sure this is the right way, but ¯\_(ツ)_/¯)
* respect a font’s UPM * don’t expect non-suffixed figures to exist
for both Defcon and fontTools fonts
* make the argument order more logical * use helper module to get family name * further work toward supporting font files
* collect mark-to-base, mark-to-mark, and mark-to-ligature anchors * draw anchors for both fonts and UFOs if requested
they improve code organization, speed, and readability
that name makes more sense to me
josh-hadley
approved these changes
Aug 5, 2025
Contributor
josh-hadley
left a comment
josh-hadley
left a comment
There was a problem hiding this comment.
@frankrolf nice upgrade! I think this is fine as-is, but for a future update we should consider getting this into PyPI (although we'll want to more prominently document that this is Mac-only). It might also be nice to set up and automate some basic tests & generation of documentation. But that's all optional, for later. Nice work!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a big PR, focusing on two major improvements:
pip(which should make it much more accessible).glyphProofUFO) and figureSpacingProofBeyond that, there have been a lot of individual fixes and updates, which help consistency, speed, and (hopefully) readability.