get rid of overzealous anchor_name_no_underscore#17
Merged
frankrolf merged 2 commits intoadobe-type-tools:masterfrom Oct 20, 2022
arialcrime:master
Merged
get rid of overzealous anchor_name_no_underscore#17frankrolf merged 2 commits intoadobe-type-tools:masterfrom arialcrime:master
frankrolf merged 2 commits intoadobe-type-tools:masterfrom
arialcrime:master
Conversation
otherwise class names and their references in the final code don’t match
Member
|
Thank you for this report. As I read in my own code: ❝The anchor_name_no_underscore process is odd❞. The original intent for this fix was allowing glyph names with colons. At the same time, I made the assumption that anchors would not contain more underscores than a single leading one, which was the cause for the issue on your end. I suggest the following, simplified fix (which allows for both scenarios): |
frankrolf
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
otherwise class names and their references in the final code don’t match