Skip to content

Add files via upload#5

Merged
miguelsousa merged 1 commit intoadobe-type-tools:masterfrom
Arno-Enslin:master
Jun 3, 2016
Merged

Add files via upload#5
miguelsousa merged 1 commit intoadobe-type-tools:masterfrom
Arno-Enslin:master

Conversation

@Arno-Enslin
Copy link
Contributor

Changes because of new No Flex option in Autohint.py

@miguelsousa
Copy link
Member

where did this plistlib.py script come from and why is it needed?

@Arno-Enslin
Copy link
Contributor Author

Arno-Enslin commented Jun 3, 2016

Hi Miguel,

where did this plistlib.py script come from […] ?

It comes from adobe-type-tools/afdko/tree/master/FDK/Tools/SharedData/FDKScripts.

[…] and why is it needed?

Because of this line in the macro "Autohint.py":

import plistlib

But I just have seen, that it was never contained in the modules directory of FDK/Tools/Fontlab(Macros). Older versions of "installFontLabMacros.py" got it from "…/Tools/SharedData/FDKScripts".

But because you have sourced out the FontLab directory from the AFDKO, I don't know, if "installFontLabMacros.py" should be changed again.

Please have a look at this issue discussion / monologue [;‑)].

And please let me know, if you know, how I can access the FontLab checkbox "Automatically generate Flex hints in T1 and OT-PS fonts", because I would like to add an option to Autohint.py for turning this on/off.

@miguelsousa
Copy link
Member

OK.

let me know, if you know, how I can access the FontLab checkbox "Automatically generate Flex hints in T1 and OT-PS fonts"

I don't.

@miguelsousa miguelsousa merged commit 568ac8f into adobe-type-tools:master Jun 3, 2016
@frankrolf
Copy link
Member

plistlib.py is a built-in Python module and hence should not be in this repository.
https://docs.python.org/2/library/plistlib.html

@Arno-Enslin
Copy link
Contributor Author

Arno-Enslin commented Jun 3, 2016

@ Frank

Plistlib.py is not contained in the lib of Python 2.4. But FontLab Studio 5.04 needs Python 2.3 or 2.4 for the macros as far as I know.

And Plistlib.py was copied to the FontLab directory "Macros/System/Modules" by older versions of "installFontLabMacros.py".

If Plistlib.py is not in the modules directory, FontLab posts an error message, if you start the macro Autohint.py. By the way: The name of the macro is almost identical with the name of the command line version (autohint.py). I would rename Autohint.py to Autohint_Macro.py.

Edit:

But probably Plistlib.py could be imported from the AFDKO (Python Lib or the FDKScripts directory), because the macro Autohint.py requires autohintexe and therefore the AFDKO must be installed, if you run the macro Autohint.py.

Edit 2:

And the plistlib.py, which I had uploaded to the modules directory, coms from the FDKScripts directory, but not from the Python 2.7 lib. Plistlib.py from the Python 2.7 lib is different from the version contained in FDKScripts. (I have not checked, if both versions work with the macro Autohint.py.)

@frankrolf
Copy link
Member

The “current” version of FLS on Windows is 5.2, which uses Python 2.7.

@Arno-Enslin
Copy link
Contributor Author

I know. But I don't use FLS 5.2. Too many bugs. FLS 5.04 is relatively stable on Windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants