-
Notifications
You must be signed in to change notification settings - Fork 79
CIF-1115 - Allow product dnd on product carousel #158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- added sling POST processor to add products to the array property - modified carousel to support products paths and skus
- format copyright header
Codecov Report
@@ Coverage Diff @@
## master #158 +/- ##
=============================================
- Coverage 83.47% 54.92% -28.55%
- Complexity 395 406 +11
=============================================
Files 50 140 +90
Lines 1452 3814 +2362
Branches 118 665 +547
=============================================
+ Hits 1212 2095 +883
- Misses 161 1636 +1475
- Partials 79 83 +4
Continue to review full report at Codecov.
|
| * | ||
| */ | ||
| @Component(service = { SlingPostProcessor.class }) | ||
| public class MultiFieldDropTargetPostProcessor implements SlingPostProcessor { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it possible to scope this servlet somehow to our CIF components? I'm wondering what would happen if a customer already has a custom drop target servlet like this for other components?
At least we should mention this in the documentation or component readme.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's kind of scoped because it only handles property keys starting with ./dropTarget-> so it could only "collide with itself" if a customer already uses the same post processor. I will extend the documentation or component readme.
- extend documentation
- changed property prefix to "multiDropTarget->"
Description
This PR adds the possibility to add products to the carousel with drag'n'drop, and extends the array of products with each new product added to the carousel.
How Has This Been Tested?
Added unit tests and manually tested.
Types of changes
Checklist: