Skip to content

Conversation

@herzog31
Copy link
Member

Description

  • Security related update of NPM dependencies to make npm audit pass.

How Has This Been Tested?

  • Unit tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

@herzog31 herzog31 added the bug Something isn't working label Dec 19, 2019
@herzog31 herzog31 requested review from dplaton and mhaack December 19, 2019 14:47
@codecov
Copy link

codecov bot commented Dec 19, 2019

Codecov Report

Merging #171 into master will increase coverage by 0.3%.
The diff coverage is 88.63%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master     #171     +/-   ##
===========================================
+ Coverage     55.89%   56.19%   +0.3%     
- Complexity      406      419     +13     
===========================================
  Files           140      141      +1     
  Lines          3818     3849     +31     
  Branches        668      671      +3     
===========================================
+ Hits           2134     2163     +29     
- Misses         1601     1604      +3     
+ Partials         83       82      -1
Flag Coverage Δ Complexity Δ
#jest 37.89% <ø> (ø) 0 <ø> (ø) ⬇️
#karma 93.66% <ø> (ø) 0 <ø> (ø) ⬇️
#unittests 81.65% <88.63%> (+0.3%) 419 <16> (+13) ⬆️
Impacted Files Coverage Δ Complexity Δ
...al/models/v1/categorylist/CategoriesRetriever.java 100% <ø> (ø) 4 <0> (?)
...dels/v1/categorylist/FeaturedCategoryListImpl.java 80% <83.33%> (+2.22%) 5 <2> (-1) ⬇️
.../models/retriever/AbstractCategoriesRetriever.java 89.47% <89.47%> (ø) 14 <14> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e2c457...9db3399. Read the comment docs.

@herzog31 herzog31 merged commit 2057295 into master Dec 19, 2019
@herzog31 herzog31 deleted the trivial/fix-dependencies branch December 19, 2019 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants