Skip to content

Conversation

@LSantha
Copy link
Collaborator

@LSantha LSantha commented Jan 22, 2020

  • removed unused file CommerceApi.js
  • removed /magento/img entries from dispatcher config

Related Issue

CIF-1205

Motivation and Context

How Has This Been Tested?

Manually.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

 * removed unused file CommerceApi.js
 * removed /magento/img entries from dispatcher config
@codecov
Copy link

codecov bot commented Jan 22, 2020

Codecov Report

Merging #181 into master will increase coverage by 0.16%.
The diff coverage is 92.15%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #181      +/-   ##
============================================
+ Coverage     57.88%   58.04%   +0.16%     
- Complexity      474      482       +8     
============================================
  Files           148      148              
  Lines          4184     4205      +21     
  Branches        719      724       +5     
============================================
+ Hits           2422     2441      +19     
- Misses         1669     1670       +1     
- Partials         93       94       +1
Flag Coverage Δ Complexity Δ
#jest 37.56% <ø> (ø) 0 <ø> (ø) ⬇️
#karma 94.53% <ø> (ø) 0 <ø> (ø) ⬇️
#unittests 82.66% <92.15%> (+0.11%) 482 <14> (+8) ⬆️
Impacted Files Coverage Δ Complexity Δ
...models/v1/relatedproducts/RelatedProductsImpl.java 85.36% <ø> (-2.44%) 14 <0> (ø)
...nal/models/v1/searchresults/SearchResultsImpl.java 95.74% <ø> (-2.13%) 17 <0> (ø)
...nternal/models/v1/productlist/ProductListImpl.java 73.8% <ø> (-1.2%) 26 <0> (ø)
...nal/models/v1/productlist/ProductListItemImpl.java 100% <100%> (ø) 9 <2> (ø) ⬇️
...nal/models/v1/productteaser/ProductTeaserImpl.java 56.86% <100%> (-1.14%) 16 <0> (ø)
.../internal/models/v1/teaser/CommerceTeaserImpl.java 94.11% <100%> (+19.11%) 10 <0> (+1) ⬆️
...nal/models/v1/teaser/CommerceTeaserActionItem.java 90.9% <100%> (+0.9%) 4 <0> (ø) ⬇️
.../internal/models/v1/navigation/NavigationImpl.java 86.2% <100%> (ø) 23 <0> (ø) ⬇️
...models/v1/productcarousel/ProductCarouselImpl.java 69.56% <100%> (-2.18%) 12 <0> (ø)
...s/internal/servlets/SpecificPageFilterFactory.java 90.9% <100%> (+10.26%) 6 <0> (-2) ⬇️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dedffaf...9f510c5. Read the comment docs.

@herzog31 herzog31 added the bug Something isn't working label Jan 23, 2020
@herzog31 herzog31 merged commit 1b5c987 into master Jan 28, 2020
@herzog31 herzog31 deleted the CIF-1205 branch January 28, 2020 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working verified

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants