Skip to content

Conversation

@herzog31
Copy link
Member

Description

Currently, Venia uses a feature in their store front that display a category image on the category page. By implementing this feature in our AEM Venia store front, we can make our store front visually more appealing.

  • Because of API changes in the sling model, I bumped the current snapshot version to 2.0.
  • Added image to product list component. Will only be displayed when showImage property from the design dialog is true and the category has an actual image.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

@codecov-io
Copy link

codecov-io commented Jun 26, 2019

Codecov Report

Merging #68 into master will decrease coverage by 0.46%.
The diff coverage is 23.07%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #68      +/-   ##
============================================
- Coverage     63.61%   63.15%   -0.47%     
- Complexity      166      168       +2     
============================================
  Files            28       28              
  Lines           984      996      +12     
  Branches         64       64              
============================================
+ Hits            626      629       +3     
- Misses          329      338       +9     
  Partials         29       29
Flag Coverage Δ Complexity Δ
#karma 94.39% <ø> (ø) 0 <ø> (ø) ⬇️
#unittests 53.66% <23.07%> (-0.46%) 168 <2> (+2)
Impacted Files Coverage Δ Complexity Δ
...ore/components/models/productlist/ProductList.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...nternal/models/v1/productlist/ProductListImpl.java 30.76% <27.27%> (-0.09%) 16 <2> (+2)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 205ce49...5a62792. Read the comment docs.

@herzog31 herzog31 merged commit 81cf3a9 into master Jul 1, 2019
@herzog31 herzog31 deleted the issue/CIF-899 branch July 1, 2019 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants