Accessibility Add-On #1133
Merged
Accessibility Add-On #1133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1133 +/- ##
=========================================
Coverage 80.75% 80.75%
Complexity 773 773
=========================================
Files 91 91
Lines 2110 2110
Branches 285 285
=========================================
Hits 1704 1704
Misses 252 252
Partials 154 154 ☔ View full report in Codecov by Sentry. |
Lighthouse scores (desktop)
|
Lighthouse scores (mobile)
|
devgurjar
reviewed
Mar 20, 2024
| data-cmp-data-layer="${numberinput.data.json}" | ||
| min="${numberinput.minimum}" | ||
| disabled="${!numberinput.enabled}" | ||
| readonly="${numberinput.readOnly}" |
Contributor
There was a problem hiding this comment.
Do we required this readOnly attribute in all components, as you've removed it in radiobutton.
Contributor
Author
There was a problem hiding this comment.
readonly attribute is not supported on radio buttons. Radio buttons allow users to select one option from a group of options. Making individual radio buttons readonly doesn't make sense because the purpose of radio buttons is to allow selection. Making them readonly will not serve the purpose.
pavi41
force-pushed
the
accessibility-addon
branch
from
72dff61 to
7d29e15
Compare
Lighthouse scores (mobile)
|
Lighthouse scores (desktop)
|
rismehta
reviewed
Mar 20, 2024
...in/content/jcr_root/apps/core/fd/components/form/radiobutton/v1/radiobutton/radiobutton.html
Outdated
Show resolved
Hide resolved
rismehta
requested changes
Mar 20, 2024
Collaborator
rismehta
left a comment
rismehta
left a comment
There was a problem hiding this comment.
Please add test case in runtime spec of individual component which checks for these accessibility attributes which we have added
amit-mnnit
reviewed
Mar 20, 2024
amit-mnnit
reviewed
Mar 20, 2024
amit-mnnit
reviewed
Mar 20, 2024
...main/content/jcr_root/apps/core/fd/components/af-commons/v1/fieldTemplates/errorMessage.html
Show resolved
Hide resolved
amit-mnnit
requested changes
Mar 20, 2024
Contributor
amit-mnnit
left a comment
amit-mnnit
left a comment
There was a problem hiding this comment.
Please check comments
pavi41
force-pushed
the
accessibility-addon
branch
2 times, most recently
from
b40976d to
6bc981d
Compare
Lighthouse scores (mobile)
|
Lighthouse scores (desktop)
|
Accessibility Violations Found
|
2 similar comments
Accessibility Violations Found
|
Accessibility Violations Found
|
pavi41
force-pushed
the
accessibility-addon
branch
from
6bc981d to
be58214
Compare
github-actions
bot
force-pushed
the
accessibility-addon
branch
from
be58214 to
03c57e1
Compare
Lighthouse scores (desktop)
|
Lighthouse scores (mobile)
|
Accessibility Violations Found
|
2 similar comments
Accessibility Violations Found
|
Accessibility Violations Found
|
pavi41
force-pushed
the
accessibility-addon
branch
from
03c57e1 to
6331c6a
Compare
Lighthouse scores (desktop)
|
Lighthouse scores (mobile)
|
Accessibility Violations Found
|
2 similar comments
Accessibility Violations Found
|
Accessibility Violations Found
|
Lighthouse scores (desktop)
|
Lighthouse scores (mobile)
|
Accessibility Violations Found
|
2 similar comments
Accessibility Violations Found
|
Accessibility Violations Found
|
rismehta
reviewed
Mar 26, 2024
| required="${telText.required}" | ||
| placeholder="${telText.placeHolder}" | ||
| autocomplete="${telText.autoComplete}" | ||
| aria-describedby="${telText.id}__errormessage ${telText.id}__longdescription ${telText.id}__shortdescription" |
Collaborator
There was a problem hiding this comment.
Have we done these changes in the headless component as well ?
rismehta
approved these changes
Mar 26, 2024
Collaborator
rismehta
left a comment
rismehta
left a comment
There was a problem hiding this comment.
Can you please update the headless component as well with these changes ?
pavi41
force-pushed
the
accessibility-addon
branch
from
6331c6a to
ab92be0
Compare
Lighthouse scores (mobile)
|
Lighthouse scores (desktop)
|
Accessibility Violations Found
|
2 similar comments
Accessibility Violations Found
|
Accessibility Violations Found
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: