Added Aria Invalid attribute #1149

pavi41 · 2024-03-27T08:26:10Z

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

I have signed the Adobe Open Source CLA.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes and the overall coverage did not decrease.
All unit tests pass on CircleCi.
I ran all tests locally and they pass.

adobe-bot · 2024-03-27T08:48:45Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

ui.frontend/src/view/FormFieldBase.js

ui.af.apps/src/main/content/jcr_root/apps/core/fd/components/form/text/v1/text/text.html

rismehta

looks like PR is not in reviewable state

adobe-bot · 2024-03-28T09:18:42Z

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	100	100	73

adobe-bot · 2024-03-28T09:18:42Z

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	90	100	100	73

adobe-bot · 2024-03-28T09:18:53Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

adobe-bot · 2024-03-28T09:20:59Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

adobe-bot · 2024-03-28T09:21:34Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

adobe-bot · 2024-03-28T10:03:40Z

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	100	100	73

adobe-bot · 2024-03-28T10:03:40Z

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	94	100	100	73

adobe-bot · 2024-03-28T10:03:51Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

adobe-bot · 2024-03-28T10:04:36Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

adobe-bot · 2024-03-28T10:05:46Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

ui.frontend/src/view/FormOptionFieldBase.js

ui.frontend/src/view/FormFieldBase.js

rismehta

check comments

adobe-bot · 2024-04-01T09:27:15Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

adobe-bot · 2024-04-01T10:07:13Z

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	94	100	100	73

adobe-bot · 2024-04-01T10:07:13Z

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	100	100	73

adobe-bot · 2024-04-01T10:07:23Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

adobe-bot · 2024-04-01T10:11:55Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

adobe-bot · 2024-04-01T10:37:58Z

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	100	100	73

adobe-bot · 2024-04-01T10:37:58Z

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	93	100	100	73

adobe-bot · 2024-04-03T12:36:35Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

adobe-bot · 2024-04-03T12:36:54Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

adobe-bot · 2024-04-03T12:41:29Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

adobe-bot · 2024-04-05T14:31:19Z

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	93	100	100	73

adobe-bot · 2024-04-05T14:31:19Z

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	100	100	73

adobe-bot · 2024-04-05T14:31:30Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

adobe-bot · 2024-04-05T14:32:21Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

adobe-bot · 2024-04-05T14:33:14Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

...re/fd/components/form/checkboxgroup/v1/checkboxgroup/clientlibs/site/js/checkboxgroupview.js

...in/content/jcr_root/apps/core/fd/components/form/radiobutton/v1/radiobutton/radiobutton.html

ui.frontend/src/utils.js

ui.frontend/src/view/FormFieldBase.js

adobe-bot · 2024-04-08T16:32:09Z

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	91	100	100	73

adobe-bot · 2024-04-08T16:32:09Z

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	100	100	73

adobe-bot · 2024-04-08T16:32:19Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

adobe-bot · 2024-04-08T16:32:57Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

adobe-bot · 2024-04-08T16:33:15Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

Co-authored-by: Pavitra Khatri <pavitrakhatri@Pavitras-MacBook-Pro.local>

rismehta reviewed Mar 27, 2024

View reviewed changes

ui.frontend/src/view/FormFieldBase.js Outdated Show resolved Hide resolved

rismehta reviewed Mar 27, 2024

View reviewed changes

ui.af.apps/src/main/content/jcr_root/apps/core/fd/components/form/text/v1/text/text.html Show resolved Hide resolved

rismehta requested changes Mar 27, 2024

View reviewed changes

pavi41 force-pushed the acc/add branch from 08727d5 to 1b9b1f6 Compare March 28, 2024 08:52

github-actions bot force-pushed the acc/add branch from 1b9b1f6 to 58b0ed4 Compare March 28, 2024 08:52

rismehta reviewed Mar 28, 2024

View reviewed changes

ui.frontend/src/view/FormOptionFieldBase.js Outdated Show resolved Hide resolved

rismehta reviewed Mar 28, 2024

View reviewed changes

ui.frontend/src/view/FormFieldBase.js Show resolved Hide resolved

rismehta requested changes Mar 28, 2024

View reviewed changes

pavi41 force-pushed the acc/add branch from 58b0ed4 to 0daa006 Compare April 1, 2024 08:59

github-actions bot force-pushed the acc/add branch from 0daa006 to d85dd1e Compare April 1, 2024 08:59

pavi41 force-pushed the acc/add branch from d85dd1e to efa4926 Compare April 1, 2024 09:47

github-actions bot force-pushed the acc/add branch from efa4926 to fc07211 Compare April 1, 2024 09:47

pavi41 force-pushed the acc/add branch from 2cdf250 to 3b2cb96 Compare April 5, 2024 14:09

github-actions bot force-pushed the acc/add branch from 3b2cb96 to 1f8f038 Compare April 5, 2024 14:09

sakshi-arora1 reviewed Apr 8, 2024

View reviewed changes

...re/fd/components/form/checkboxgroup/v1/checkboxgroup/clientlibs/site/js/checkboxgroupview.js Outdated Show resolved Hide resolved

sakshi-arora1 reviewed Apr 8, 2024

View reviewed changes

...in/content/jcr_root/apps/core/fd/components/form/radiobutton/v1/radiobutton/radiobutton.html Show resolved Hide resolved

sakshi-arora1 reviewed Apr 8, 2024

View reviewed changes

ui.frontend/src/utils.js Show resolved Hide resolved

sakshi-arora1 reviewed Apr 8, 2024

View reviewed changes

ui.frontend/src/view/FormFieldBase.js Show resolved Hide resolved

pavi41 force-pushed the acc/add branch from 1f8f038 to 58ae469 Compare April 8, 2024 16:01

Added Aria Invalid attribute

1bf677f

github-actions bot force-pushed the acc/add branch from 58ae469 to 1bf677f Compare April 8, 2024 16:01

sakshi-arora1 approved these changes Apr 9, 2024

View reviewed changes

barshat7 approved these changes Apr 9, 2024

View reviewed changes

pavi41 requested a review from rismehta April 9, 2024 10:09

rismehta approved these changes Apr 9, 2024

View reviewed changes

rismehta merged commit 0f44964 into dev Apr 9, 2024

rismehta deleted the acc/add branch April 9, 2024 11:10

github-actions bot pushed a commit that referenced this pull request Apr 9, 2024

Added Aria Invalid attribute (#1149)

1f19bd4

Co-authored-by: Pavitra Khatri <pavitrakhatri@Pavitras-MacBook-Pro.local>

github-actions bot pushed a commit that referenced this pull request May 7, 2024

Added Aria Invalid attribute (#1149)

2532f2d

Co-authored-by: Pavitra Khatri <pavitrakhatri@Pavitras-MacBook-Pro.local>

Added Aria Invalid attribute #1149

Added Aria Invalid attribute #1149

Uh oh!

Conversation

pavi41 commented Mar 27, 2024

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Checklist:

Uh oh!

adobe-bot commented Mar 27, 2024

Accessibility Violations Found

Uh oh!

Uh oh!

Uh oh!

rismehta left a comment

Choose a reason for hiding this comment

Uh oh!

adobe-bot commented Mar 28, 2024

Lighthouse scores (desktop)

Uh oh!

adobe-bot commented Mar 28, 2024

Lighthouse scores (mobile)

Uh oh!

adobe-bot commented Mar 28, 2024

Accessibility Violations Found

Uh oh!

adobe-bot commented Mar 28, 2024

Accessibility Violations Found

Uh oh!

adobe-bot commented Mar 28, 2024

Accessibility Violations Found

Uh oh!

adobe-bot commented Mar 28, 2024

Lighthouse scores (desktop)

Uh oh!

adobe-bot commented Mar 28, 2024

Lighthouse scores (mobile)

Uh oh!

adobe-bot commented Mar 28, 2024

Accessibility Violations Found

Uh oh!

adobe-bot commented Mar 28, 2024

Accessibility Violations Found

Uh oh!

adobe-bot commented Mar 28, 2024

Accessibility Violations Found

Uh oh!

Uh oh!

Uh oh!

rismehta left a comment

Choose a reason for hiding this comment

Uh oh!

adobe-bot commented Apr 1, 2024

Accessibility Violations Found

Uh oh!

adobe-bot commented Apr 1, 2024

Lighthouse scores (mobile)

Uh oh!

adobe-bot commented Apr 1, 2024

Lighthouse scores (desktop)

Uh oh!

adobe-bot commented Apr 1, 2024

Accessibility Violations Found

Uh oh!

adobe-bot commented Apr 1, 2024

Accessibility Violations Found

Uh oh!

adobe-bot commented Apr 1, 2024

Lighthouse scores (desktop)

Uh oh!

adobe-bot commented Apr 1, 2024

Lighthouse scores (mobile)

Uh oh!

adobe-bot commented Apr 3, 2024

Accessibility Violations Found

Uh oh!