datepicker readonly does not work when edit or display format set #1171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lighthouse scores (desktop)
|
Lighthouse scores (mobile)
|
Accessibility Violations Found
|
2 similar comments
Accessibility Violations Found
|
Accessibility Violations Found
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1171 +/- ##
=========================================
Coverage 80.75% 80.75%
Complexity 773 773
=========================================
Files 91 91
Lines 2110 2110
Branches 285 285
=========================================
Hits 1704 1704
Misses 252 252
Partials 154 154 ☔ View full report in Codecov by Sentry. |
rismehta
reviewed
Apr 8, 2024
| }); | ||
| }); | ||
|
|
||
| it.only("should not show calendar widget if marked readonly", () => { |
rismehta
requested changes
Apr 8, 2024
Collaborator
rismehta
left a comment
rismehta
left a comment
There was a problem hiding this comment.
minor comment, else changes looks good now. Can you also add test case to update read only via JS API in the cypress test case, so that the other piece of code also has the required coverage ?
github-actions
bot
force-pushed
the
datepicker-issue-readonly
branch
from
ef9889d to
62043ac
Compare
rismehta
approved these changes
Apr 10, 2024
Lighthouse scores (mobile)
|
Lighthouse scores (desktop)
|
Accessibility Violations Found
|
2 similar comments
Accessibility Violations Found
|
Accessibility Violations Found
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: