Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ui.frontend/src/view/FormContainer.js
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,9 @@ class FormContainer {
#preventDefaultSubmit(){
if(this._element) {
this._element.addEventListener('keydown', (event) => {
if (event.key === 'Enter') {
const target = event.target;
const isSubmitOrReset = target.tagName === 'INPUT' && (target.type === 'submit' || target.type === 'reset');
if (event.key === 'Enter' && target.tagName !== 'SELECT' && target.tagName !== 'BUTTON' && !isSubmitOrReset) {
event.preventDefault();
}
});
Expand Down
26 changes: 24 additions & 2 deletions ui.tests/test-module/specs/formcontainer.cy.js
Original file line number Diff line number Diff line change
Expand Up @@ -290,16 +290,38 @@ describe('Page/Form Authoring', function () {

context("Check default behaviour in Form Editor", function () {
const pagePath = "/content/forms/af/core-components-it/samples/numberinput/validation.html";

let formContainerModel = null
beforeEach(function () {
cy.previewForm(pagePath);
cy.previewForm(pagePath).then(p => {
formContainerModel = p;
})
});

it('check the preventDefaultSubmit method by simulating keydown event on the form', function () {
cy.get('.cmp-adaptiveform-container').then((formContainer) => {
const [id, fieldView] = Object.entries(formContainerModel._fields)[0]

cy.stub(formContainer[0], 'onsubmit').as('submit');
cy.get('form').trigger('keydown', {key: 'Enter'});
cy.get('@submit').should('not.be.called');

// Trigger enter on a text input (should prevent submission)
cy.get('input[type="text"]').first().type('{enter}');
cy.get(`#${id} .cmp-adaptiveform-numberinput__errormessage`).should('not.have.text', 'This is required numberinput');


});
});


it('button click should work on press of enter key', function () {
cy.get('.cmp-adaptiveform-container').then((formContainer) => {
const [id, fieldView] = Object.entries(formContainerModel._fields)[0]

// Trigger enter on a button (should not prevent submission)
cy.get('button').first().type('{enter}');
cy.get(`#${id} .cmp-adaptiveform-numberinput__errormessage`).should('have.text', 'This is required numberinput');

});
});

Expand Down
Loading