-
Notifications
You must be signed in to change notification settings - Fork 64
Fixing positional enter in text area. #1610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1610 +/- ##
=========================================
Coverage 82.34% 82.34%
Complexity 1003 1003
=========================================
Files 108 108
Lines 2611 2611
Branches 373 373
=========================================
Hits 2150 2150
Misses 272 272
Partials 189 189 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
(cherry picked from commit a4f2f4f)
|
Why was this merged without test case ? |
@rismehta we already have a test case for newline charachter https://github.com/adobe/aem-core-forms-components/blob/dev/ui.tests/test-module/specs/textinput/textinput.runtime.cy.js#L150 and it seems we can't go to a cursor location to type using cypress. I searched that, and all the solutions were to put the whole value including \n. The fix here is particularly to type \n in between. |
If we already have a test case for this use-case, then why do we need this fix ? |
This reverts commit a4f2f4f.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: