Skip to content

fix(execution): code quality step startedAt should only be overridden…#389

Merged
justinedelson merged 1 commit intomainfrom
issue/dont-set-cq-startedAt-if-build-didnt-finishx
Jul 16, 2021
Merged

fix(execution): code quality step startedAt should only be overridden…#389
justinedelson merged 1 commit intomainfrom
issue/dont-set-cq-startedAt-if-build-didnt-finishx

Conversation

@justinedelson
Copy link
Copy Markdown
Member

@justinedelson justinedelson commented Jul 16, 2021

… if build finished. fixes #388

Description

Only override the undefined codeQualityStep.startedAt if the build step finished

Related Issue

#388

Motivation and Context

Bug fix

How Has This Been Tested?

  • Unit test
  • Manual test

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@justinedelson justinedelson force-pushed the issue/dont-set-cq-startedAt-if-build-didnt-finishx branch from 2cd175d to 498a68e Compare July 16, 2021 16:06
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 16, 2021 •
edited
Loading

Codecov Report

Merging #389 (498a68e) into main (1a5b97b) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #389   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           52        52           
  Lines         1258      1259    +1     
  Branches       151       152    +1     
=========================================
+ Hits          1258      1259    +1
Impacted Files Coverage Δ
...ommands/cloudmanager/execution/get-step-details.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a5b97b...498a68e. Read the comment docs.

@justinedelson justinedelson merged commit 40dbade into main Jul 16, 2021
github-actions Bot pushed a commit that referenced this pull request Jul 16, 2021
@semantic-release-bot
chore(release): 2.2.1 [skip ci]
6effdd8 
## [2.2.1](2.2.0...2.2.1) (2021-07-16)

### Bug Fixes

* **execution:** code quality step startedAt should only be overridden if build finished. fixes [#388](#388) ([#389](#389)) ([40dbade](40dbade))
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jul 16, 2021

🎉 This PR is included in version 2.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

When the build step is cancelled or failed, cloudmanager:execution:get-step-details shows a startedAt for the codeQuality step

1 participant

@justinedelson