Skip to content

feat(commerce): update method names. fixes#404#405

Merged
justinedelson merged 1 commit intoadobe:mainfrom
thoughtassassin:Update-Commerce-Methods
Jul 23, 2021
Merged

feat(commerce): update method names. fixes#404#405
justinedelson merged 1 commit intoadobe:mainfrom
thoughtassassin:Update-Commerce-Methods

Conversation

@thoughtassassin
Copy link
Copy Markdown
Contributor

This PR will update the methods in BaseCommerceCommand from getCLICommand and postCLICommand to getCommerceCommandExecution and postCommerceCommandExecution.

Related Issue

#404

Motivation and Context

Fixes the names of the methods to match what will be in the lib

How Has This Been Tested?

Unit tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 23, 2021

Codecov Report

Merging #405 (9559a0b) into main (40dbade) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #405   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           52        52           
  Lines         1259      1259           
  Branches       152       152           
=========================================
  Hits          1259      1259           
Impacted Files Coverage Δ
src/base-commerce-cli-command.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6effdd8...9559a0b. Read the comment docs.

@justinedelson justinedelson merged commit a999b61 into adobe:main Jul 23, 2021
github-actions Bot pushed a commit that referenced this pull request Jul 23, 2021
# [2.3.0](2.2.2...2.3.0) (2021-07-23)

### Features

* **commerce:** update method names. fixes[#404](#404) ([#405](#405)) ([a999b61](a999b61))
@github-actions
Copy link
Copy Markdown

🎉 This PR is included in version 2.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants