Skip to content

fix(start-execution): clarify emergency flag. fixes #535#536

Merged
justinedelson merged 1 commit intomainfrom
issue/clarify-emergency-flag
Oct 18, 2021
Merged

fix(start-execution): clarify emergency flag. fixes #535#536
justinedelson merged 1 commit intomainfrom
issue/clarify-emergency-flag

Conversation

@justinedelson
Copy link
Copy Markdown
Member

Description

Update flag description for emergency mode

Related Issue

#535

Motivation and Context

How Has This Been Tested?

Manual testing

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 18, 2021

Codecov Report

Merging #536 (605cc13) into main (9fa41e7) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #536   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           71        71           
  Lines         1561      1585   +24     
  Branches       184       208   +24     
=========================================
+ Hits          1561      1585   +24     
Impacted Files Coverage Δ
...commands/cloudmanager/pipeline/create-execution.js 100.00% <ø> (ø)
src/cloudmanager-helpers.js 100.00% <0.00%> (ø)
src/base-variables-command.js 100.00% <0.00%> (ø)
src/hooks/prerun/permission-info.js 100.00% <0.00%> (ø)
src/hooks/init/load-permission-info.js 100.00% <0.00%> (ø)
src/hooks/prerun/check-ims-context-config.js 100.00% <0.00%> (ø)
src/hooks/prerun/environment-id-from-config.js 100.00% <0.00%> (ø)
...commands/cloudmanager/environment/set-variables.js 100.00% <0.00%> (ø)
...ommands/cloudmanager/program/list-ip-allowlists.js 100.00% <0.00%> (ø)
...s/cloudmanager/ip-allowlist/get-binding-details.js 100.00% <0.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fa41e7...605cc13. Read the comment docs.

@justinedelson justinedelson merged commit 143ae1c into main Oct 18, 2021
github-actions Bot pushed a commit that referenced this pull request Oct 18, 2021
## [2.21.1](2.21.0...2.21.1) (2021-10-18)

### Bug Fixes

* **start-execution:** clarify emergency flag. fixes [#535](#535) ([#536](#536)) ([143ae1c](143ae1c))
@github-actions
Copy link
Copy Markdown

🎉 This PR is included in version 2.21.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant