Skip to content

fix: remove if-modified-since from proxy request to ensure that content-type is included#2711

Merged
tripodsan merged 1 commit intomainfrom
noproxy-if-modified-since
Apr 20, 2026
Merged

fix: remove if-modified-since from proxy request to ensure that content-type is included#2711
tripodsan merged 1 commit intomainfrom
noproxy-if-modified-since

Conversation

@tripodsan
Copy link
Copy Markdown
Contributor

@tripodsan tripodsan commented Apr 20, 2026

No description provided.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 20, 2026

This PR will trigger a patch release when merged.

@tripodsan tripodsan requested a review from kptdobe April 20, 2026 12:14
kptdobe
kptdobe approved these changes Apr 20, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@kptdobe kptdobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain why / when this is a problem ?

@tripodsan
Copy link
Copy Markdown
Contributor Author

tripodsan commented Apr 20, 2026 •
edited
Loading

Can you explain why / when this is a problem ?

I debugged an issue where modifications to the local head.html where not reflected. the issue was that the response from aem.page did not include a content-type header and so it bypassed the head.html injection.

I saw that the response was a 304, since the browser included a if-modified-since. I think on a 304 it is ok for the CDN to omit the content-type header. (most of the devs work with cache-disabled (network tab) and then chrome doesn't send the if-modified-since , so I think they rarely get this issue)

@tripodsan tripodsan merged commit 482a618 into main Apr 20, 2026
8 checks passed
@tripodsan tripodsan deleted the noproxy-if-modified-since branch April 20, 2026 13:51
adobe-bot pushed a commit that referenced this pull request Apr 20, 2026
@semantic-release-bot
chore(release): 16.18.2 [skip ci]
a355fc5 
## [16.18.2](v16.18.1...v16.18.2) (2026-04-20)

### Bug Fixes

* remove if-modified-since from proxy request to ensure that content-type is included ([#2711](#2711)) ([482a618](482a618))
@adobe-bot
Copy link
Copy Markdown
Collaborator

adobe-bot commented Apr 20, 2026

🎉 This PR is included in version 16.18.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kptdobe kptdobe kptdobe approved these changes

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tripodsan @adobe-bot @kptdobe