This repository was archived by the owner on Feb 25, 2022. It is now read-only.
test(excel): add unit test for excel #54
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR will trigger a patch release when merged. |
Contributor
|
@trieloff Fetching the workbook works for me... but then, the worksheet has no table.... I added some checks to the |
Contributor
Author
|
Did the client ID change? |
Contributor
no. |
Funny story: it turns out that Excel has worksheets that do not contain tables. These worksheets still have rows and cells and so on, but the container is a range, not a table. A table needs to be created by the user and allows feature such as filtering, sorting, etc. Anyway, this commit adds support for ranges and includes integration tests for workbooks with and workbooks without tables. The error handling code for the more unlikely scenarios (workbooks without worksheets and tables without columns) has been removed, as the testing overhead would exceed the usable value. fixes #52
Contributor
Author
|
🎉 This PR is included in version 1.4.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Branch to investigate #52