Skip to content

Conversation

@trieloff
Copy link
Contributor

Summary

  • Adds CLOUDFLARE_AUTH secret to CI workflow environment
  • Updates Cloudflare integration test to use the auth token from environment
  • Updates account ID and workers.dev subdomain for current Cloudflare account
  • Enables previously skipped Cloudflare integration test

Changes

  • .github/workflows/main.yaml:36 - Add CLOUDFLARE_AUTH environment variable
  • test/cloudflare.integration.js:38 - Remove .skip to enable test
  • test/cloudflare.integration.js:50-52 - Update account ID, test domain, and add auth parameter

Test Plan

  • Cloudflare API token verified and added as repository secret
  • CI integration tests pass with new configuration
  • Cloudflare worker successfully deploys during test

Fixes #87

🤖 Generated with Claude Code

- Add CLOUDFLARE_AUTH environment variable to CI workflow
- Update cloudflare.integration.js to use process.env.CLOUDFLARE_AUTH
- Update account ID and test domain for current Cloudflare account
- Remove .skip from Cloudflare integration test

Fixes #87

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

Signed-off-by: Lars Trieloff <lars@trieloff.net>
@codecov
Copy link

codecov bot commented Nov 20, 2025

Codecov Report

❌ Patch coverage is 78.94737% with 4 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/CloudflareDeployer.js 78.94% 4 Missing ⚠️

📢 Thoughts on this report? Let us know!

- Add enableSubdomain() method to CloudflareDeployer
- Call enableSubdomain() after worker deployment
- Use POST method to enable subdomain (not PUT)
- Increase retry404 from 0 to 5 for propagation delays
- Requires Workers Scripts:Edit permission on API token

This fixes the issue where deployed workers weren't accessible
on workers.dev due to subdomain not being enabled.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

Signed-off-by: Lars Trieloff <lars@trieloff.net>
@github-actions
Copy link

This PR will trigger a patch release when merged.

- Add POST /subdomain mock to both CloudflareDeployer tests
- Fixes unit test failures from enableSubdomain() addition

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

Signed-off-by: Lars Trieloff <lars@trieloff.net>
- Update test assertion from rockerduck to minivelos
- Matches updated account configuration

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

Signed-off-by: Lars Trieloff <lars@trieloff.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add CLOUDFLARE_AUTH secret for integration tests

3 participants