Skip to content
This repository was archived by the owner on Feb 28, 2022. It is now read-only.
This repository was archived by the owner on Feb 28, 2022. It is now read-only.

implementation detail bleeding (defaults.js) #2

@tripodsan

Description

@tripodsan

the example on how to build the pipeline shows that the defaults source file location is exposed:

// the pipeline itself
const pipeline = require("@adobe/hypermedia-pipeline");
// helper functions and log
const { adaptOWRequest, adaptOWResponse, log } = require('@adobe/hypermedia-pipeline/src/defaults/default.js');

suggestion

exports the defaults

  1. move the pipeline code to own file. eg: src/pipeline.js
  2. export pipeline and defaults in index.js:

index.js (draft):

const defaults = require('./src/defaults/defaults.js')
const pipeline = require('./src/pipeline.js')

module.exports = {
  pipeline,
  defaults
}

usage:

// the pipeline itself
const { pipeline } = require("@adobe/hypermedia-pipeline");
// helper functions and log
const { adaptOWRequest, adaptOWResponse, log } = require('@adobe/hypermedia-pipeline').defaults;

or:

const {pipeline,
  defaults: {
    adaptOWRequest, 
    adaptOWResponse, 
    log
} = require("@adobe/hypermedia-pipeline");

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions