Skip to content

Conversation

@StefanDinu
Copy link
Contributor

Upgrade the Vault code to use the new engine kv 2, which also uses namespaces. Accordingly, updating the Vault Python sdk hvac to a more modern version.

Description

  • upgrade hvac module to >0.9.x
  • modify Vault code to work with the new kv engine.
  • slight styling changes because some lines were just too long. Wish we had some PEP8 or linting enforced.

Motivation and Context

The old Vault engine has been changed within Adobe Audience Manager.

How Has This Been Tested?

Built an ops docker image from my fork & branch, tested against CNS infrastructure that was using read_vault()

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • All new and existing tests passed.

@amuraru
Copy link
Contributor

amuraru commented Jul 17, 2019

please rebase and re-test

@StefanDinu StefanDinu force-pushed the vault_engine_upgrade branch 2 times, most recently from 8826c8c to 8a6d4ab Compare July 18, 2019 15:04
@StefanDinu StefanDinu force-pushed the vault_engine_upgrade branch from 8a6d4ab to 610c559 Compare July 19, 2019 12:01
@StefanDinu StefanDinu merged commit 76e5603 into adobe:master Jul 19, 2019
@StefanDinu StefanDinu deleted the vault_engine_upgrade branch July 19, 2019 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants