Enchance Vault utils #54
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
costimuraru
reviewed
Aug 14, 2019
src/ops/cli/terraform.py
Outdated
| self.cluster_config = cluster_config | ||
| # Check if the cluster_config has a strict requirement of OPS version | ||
| # But only if 'ops_min_version' is specified. Not all clusters configs enforce this | ||
| if "ops_min_version" in self.cluster_config.conf["terraform"]: |
Contributor
There was a problem hiding this comment.
- To keep things more easy to read, what do you think about extracting this code block in a dedicated method
def check_ops_version()or something similar. - It's not really ideal to have this checks in the class constructor (
__init__). What do you think about having this check in therunmethod? - It's possible that for newer integrations to not have the
terraformsection at all, in which this check would fail becauseself.cluster_config.conf["terraform"]would be None. What do you think about also adding a check such as'terraform' in self.cluster_config.conf
Contributor
Author
There was a problem hiding this comment.
Thanks for the feedback ! Will implement these
costimuraru
reviewed
Aug 14, 2019
| data = default | ||
| return data | ||
| # if the provided secret path doesn't exist, return false | ||
| return False |
Contributor
There was a problem hiding this comment.
Shouldn't we return the default value if the secret does not exist?
Never mind, I see this is in the check method.
StefanDinu
force-pushed
the
ops_vault_enhancements
branch
from
b285d5a to
37ae881
Compare
costimuraru
approved these changes
Aug 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhance Vault modules and add support for enforcing a minimum ops version in Terraform clusters.
Addresses issue #55
Description
Motivation and Context
How Has This Been Tested?
Built the ops Docker container locally from sources, ran Terraform plan and apply on our clusters.
Also tested with older versions of ops which now fail because another PR will introduce a new function in the TF modules that will only exist in the newer ops.
Checklist: