Skip to content

Conversation

@jewee
Copy link
Contributor

@jewee jewee commented Oct 18, 2019

When cluster.fqdn is missing helmfile may execute against wrong cluster

Description

Exception is raised is the necessary keys are not found in cluster definition

Related Issue

#84

Motivation and Context

How Has This Been Tested?

By executing agains a cluster definition that does not have all the necessary keys to generate cluster config context.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@pep8speaks
Copy link

pep8speaks commented Oct 18, 2019

Hello @jewee! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-10-18 18:08:47 UTC

@jewee jewee merged commit 4de48ad into adobe:master Oct 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants