An 339629/scatter trendlines #118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎨 Storybook -> https://opensource.adobe.com/react-spectrum-charts/PR-118 |
|
🎨 Storybook -> https://opensource.adobe.com/react-spectrum-charts/PR-118 |
olsonjb
reviewed
Feb 8, 2024
Comment on lines
461
to
464
|
|
||
| // export const isLineTypeArray = (lineTypes: LineTypes): lineTypes is LineType[] => { | ||
| // return lineTypes.some((lineType) => typeof lineType === 'string' || isStrokeDashArray(lineType)); | ||
| // }; |
Contributor
There was a problem hiding this comment.
Did this guy just get forgotten? :)
Member
Author
There was a problem hiding this comment.
Good catch. I pasted that there as a reference of how to write a typeguard.
|
|
🎨 Storybook -> https://opensource.adobe.com/react-spectrum-charts/PR-118 |
olsonjb
approved these changes
Feb 8, 2024
Contributor
olsonjb
left a comment
olsonjb
left a comment
There was a problem hiding this comment.
Looks great! I think it'd be nice to fit another story under Scatter or Trendline, but I don't think it's a must have
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support trendlines for scatter plots
Motivation and Context
Trendlines should be supported by all continuous chart types
How Has This Been Tested?
Existing tests pass. New tests were added
Screenshots (if appropriate):
Types of changes
Checklist: