feat: tooltip point highlighting on scatter #130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎨 Storybook -> https://opensource.adobe.com/react-spectrum-charts/PR-130 |
|
|
🎨 Storybook -> https://opensource.adobe.com/react-spectrum-charts/PR-130 |
|
|
||
| await hoverNthElement(paths, 0); | ||
| expect(points[0]).toHaveAttribute('opacity', '1'); | ||
| expect(points[1]).toHaveAttribute('opacity', `${1 / HIGHLIGHT_CONTRAST_RATIO}`); |
Contributor
There was a problem hiding this comment.
Super nit:
I think we can remove this, but maybe in another PR since everything else looks great!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add highlighting to scatter points when the tooltip is visible
Related Issue
Scatter plot
Motivation and Context
Highlighting helps convey which point the tooltip is for
How Has This Been Tested?
Added tests. All existing tests are passing.
Screenshots (if appropriate):
Screen.Recording.2024-02-15.at.1.28.12.PM.mov
Stories
Scatter > Tooltip
Types of changes
Checklist: