refactor: switch highlight to use opacity instead of fillOpacity and …

[marshallpete]

…strokeOpacity

Description

Refactor so that highlight styling uses opacity instead of fillOpacity and strokeOpacity.

fillOpacity and strokeOpacity are still used to set the default opacity state respectively.

The advantage of this is it simplifies the highlight logic significantly and it makes the faded state more accurate. When using the stroke and fill opacities to fade a mark, the area where the two overlap gets exaggerated. Lowering the opacity as a whole using opacity doesn't for this.

How Has This Been Tested?

Validated with like 200 tests (no exaggeration)

Screenshots (if appropriate):

before:

after:

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• I have signed the Adobe Open Source CLA.
• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
92.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[github-actions]

🎨 Storybook -> https://opensource.adobe.com/react-spectrum-charts/PR-131