Skip to content

Conversation

@marshallpete
Copy link
Member

Description

Add some presets for numberValue

  • currency ($2.50)
  • shortCurrency ($20M)
  • shortNumber (3B)
  • standardNumber (2,500)

Stories

Axis > NumberFormat

Screenshots (if appropriate):

image image image image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

@amyfitzgeraldking amyfitzgeraldking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you for doing this.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 8, 2024

@github-actions
Copy link

github-actions bot commented Mar 8, 2024

@marshallpete marshallpete merged commit d32734f into main Mar 8, 2024
@marshallpete marshallpete deleted the numberFormatPlus branch March 8, 2024 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants