API bugs - will revert this one after API audit fixes are merged

Author: reidbarber

packages/dev/s2-docs/pages/react-aria/ColorField.mdx

@@ -22,7 +22,7 @@ export const description = 'Allows users to edit a hex color or individual color
     docs={vanillaDocs.exports.ColorField}
     links={vanillaDocs.links}
     props={['label', 'colorSpace', 'channel', 'description', 'isDisabled']}
-    initialProps={{label: 'Color', defaultValue: '#ff0000', placeholder: 'Enter a color'}}
+    initialProps={{label: 'Color', defaultValue: '#ff0000'}}
     type="vanilla"
     files={["starters/docs/src/ColorField.tsx", "starters/docs/src/ColorField.css"]} />
   <VisualExample
@@ -52,7 +52,6 @@ function Example() {
     <div>
       <ColorField
         label="Primary color"
-        placeholder="Enter a color"
         value={value ?? undefined}
         onChange={setValue} />
       <pre style={{fontSize: 12}}>Current value: {value?.toString('hex')}</pre>

packages/dev/s2-docs/pages/react-aria/ComboBox.mdx

@@ -91,7 +91,6 @@ function Example() {
     /*- begin highlight -*/
     <ComboBox
       label="Preferred fruit or vegetable"
-      placeholder="Select an option"
       defaultItems={options}>
       {section => (
         <ListBoxSection id={section.name}>
@@ -124,7 +123,6 @@ function Example() {
     <div>
       <ComboBox
         label="Favorite Animal"
-        placeholder="Select an animal"
         /*- begin highlight -*/
         selectedKey={animal ?? undefined}
         onSelectionChange={setAnimal}>
@@ -159,7 +157,6 @@ function Example(props) {
       <ComboBox
         {...props}
         label="Favorite Animal"
-        placeholder="Select an animal"
         /*- begin highlight -*/
         /* PROPS */
         inputValue={value}
@@ -228,7 +225,6 @@ function ControlledComboBox() {
     <div>
       <ComboBox
         label="Engineering major"
-        placeholder="Select a major"
         /*- begin highlight -*/
         defaultItems={options}
         selectedKey={fieldState.selectedKey ?? undefined}
@@ -262,7 +258,6 @@ function Example() {
   return (
     <ComboBox
       label="Favorite Animal"
-      placeholder="Select an animal"
       allowsEmptyCollection
       inputValue={inputValue}
       onInputChange={setInputValue}>
@@ -297,7 +292,6 @@ import {Form} from 'vanilla-starter/Form';;
 <Form>
   <ComboBox
     label="Animal"
-    placeholder="e.g. Cat"
     /*- begin highlight -*/
     name="animal"
     isRequired

packages/dev/s2-docs/pages/s2/Breadcrumbs.mdx

@@ -27,7 +27,7 @@ import {Breadcrumbs, Breadcrumb} from '@react-spectrum/s2';
 
 ```tsx render
 "use client";
-import {Breadcrumbs, Breadcrumb, type Key} from '@react-spectrum/s2';
+import {Breadcrumbs, Breadcrumb, Collection, type Key} from '@react-spectrum/s2';
 import {useState} from 'react';
 
 function Example() {
@@ -45,8 +45,10 @@ function Example() {
 
   return (
     /*- begin highlight -*/
-    <Breadcrumbs items={breadcrumbs} onAction={navigate}>
-      {item => <Breadcrumb>{item.label}</Breadcrumb>}
+    <Breadcrumbs onAction={navigate}>
+      <Collection items={breadcrumbs}>
+        {item => <Breadcrumb key={item.id}>{item.label}</Breadcrumb>}
+      </Collection>
     </Breadcrumbs>
     /*- end highlight -*/
   );

packages/dev/s2-docs/pages/s2/TableView.mdx

@@ -213,18 +213,18 @@ import {style} from '@react-spectrum/s2/style' with {type: 'macro'};
   </TableHeader>
   <TableBody>
     {/*- begin highlight -*/}
-    <Row href="https://adobe.com/" target="_blank">
+    <Row>
       {/*- end highlight -*/}
       <Cell>Adobe</Cell>
       <Cell>https://adobe.com/</Cell>
       <Cell>January 28, 2023</Cell>
     </Row>
-    <Row href="https://google.com/" target="_blank">
+    <Row>
       <Cell>Google</Cell>
       <Cell>https://google.com/</Cell>
       <Cell>April 5, 2023</Cell>
     </Row>
-    <Row href="https://nytimes.com/" target="_blank">
+    <Row>
       <Cell>New York Times</Cell>
       <Cell>https://nytimes.com/</Cell>
       <Cell>July 12, 2023</Cell>
@@ -314,7 +314,7 @@ function TableWithDividers() {
                 <Cell
                   /*- begin highlight -*/
                   showDivider={column.showDivider}
-                  align={column.align}>
+                  align={column.align as 'start' | 'center' | 'end' | undefined}>
                   {/*- end highlight -*/}
                   {item[column.id]}
                 </Cell>
@@ -597,7 +597,7 @@ function Example(props) {
             <Cell>Water</Cell>
             <Cell>56</Cell>
           </Row>
-          <Row id="venusaur" isDisabled>
+          <Row id="venusaur">
             <Cell>Venusaur</Cell>
             <Cell>Grass, Poison</Cell>
             <Cell>83</Cell>

packages/dev/s2-docs/pages/s2/selection.mdx

@@ -872,18 +872,18 @@ import {style} from '@react-spectrum/s2/style' with {type: 'macro'};
   </TableHeader>
   <TableBody>
     {/*- begin highlight -*/}
-    <Row onAction={() => alert('Opening Games')}>
+    <Row>
     {/*- end highlight -*/}
       <Cell>Games</Cell>
       <Cell>File folder</Cell>
       <Cell>6/7/2020</Cell>
     </Row>
-    <Row onAction={() => alert('Opening Documents')}>
+    <Row>
       <Cell>Documents</Cell>
       <Cell>File folder</Cell>
       <Cell>4/7/2021</Cell>
     </Row>
-    <Row onAction={() => alert('Opening Photos')}>
+    <Row>
       <Cell>Photos</Cell>
       <Cell>File folder</Cell>
       <Cell>11/20/2010</Cell>
@@ -1201,7 +1201,7 @@ import {style} from '@react-spectrum/s2/style' with {type: 'macro'};
       <Cell>56</Cell>
     </Row>
     {/*- begin highlight -*/}
-    <Row id="venusaur" isDisabled>
+    <Row id="venusaur">
     {/*- end highlight -*/}
       <Cell>Venusaur</Cell>
       <Cell>Grass, Poison</Cell>