Support "aria-keyshortcuts" in react-aria-components

[gregberge]

Provide a general summary of the feature here

I want to be able to set aria-keyshortcuts on a Button.

🤔 Expected Behavior?

<Button aria-keyshortcuts="S" />

It should add the property on the element.

😯 Current Behavior

It does not work.

💁 Possible Solution

No response

🔦 Context

https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Attributes/aria-keyshortcuts

💻 Examples

No response

🧢 Your Company/Team

Argos

🕷 Tracking Issue

No response

[reidbarber]

I think we could add this to AriaBaseButtonProps here:

react-spectrum/packages/@react-types/button/src/index.d.ts

Lines 49 to 63 in cef3714

	interface AriaBaseButtonProps extends FocusableDOMProps, AriaLabelingProps {
	/** Indicates whether the element, or another grouping element it controls, is currently expanded or collapsed. */
	'aria-expanded'?: boolean | 'true' | 'false',
	/** Indicates the availability and type of interactive popup element, such as menu or dialog, that can be triggered by an element. */
	'aria-haspopup'?: boolean | 'menu' | 'listbox' | 'tree' | 'grid' | 'dialog' | 'true' | 'false',
	/** Identifies the element (or elements) whose contents or presence are controlled by the current element. */
	'aria-controls'?: string,
	/** Indicates the current "pressed" state of toggle buttons. */
	'aria-pressed'?: boolean | 'true' | 'false' | 'mixed',
	/**
	* The behavior of the button when used in an HTML form.
	* @default 'button'
	*/
	type?: 'button' | 'submit' | 'reset'
	}

[snowystinger]

Just to make sure I understand, just putting the attribute on one of our elements won't do anything other than read off to AT?

It doesn't actually do anything right? If so, then I think this is fine. Though it sounds like it's supported on every HTML element? it's going to be harder to decide which components it makes sense on. What all do you want it on so far? Just button?

[reidbarber]

@snowystinger Yeah, I think just Button is a good start, and maybe Link as well.